Michael Vetter
b393363bd5
Merge pull request #1799 from profanity-im/glib276gsf
...
Adapt to g_string_free glib 2.75.3 change
2023-03-22 15:53:41 +01:00
Michael Vetter
e59c401c84
Adapt to g_string_free glib 2.75.3 change
...
glib 2.75.3 changes warning behaviour of `g_string_free()`.
See:
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226
Use this opportunity to replace the use of GString with
`g_strdup_printf()` where possible.
Otherwise correctly take the return value of `g_string_free()`
which is nicer anyways.
2023-03-21 10:53:10 +01:00
Michael Vetter
e5e8ff221a
Merge pull request #1796 from profanity-im/minor-improvements
...
Minor improvements
2023-03-13 09:18:18 +01:00
Steffen Jaeckel
2936b09a63
change OMEMO QR code 0
bits to 'space'
...
This makes the generated QR code a lot better recognizable in my case.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-12 17:39:57 +01:00
Steffen Jaeckel
091987db94
fix #1797
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-12 17:37:21 +01:00
Steffen Jaeckel
7167760bdd
fix #1761 by changing the implementation from recursive
...
... to an iterative approach
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
2925e85cd6
add test-case for #1761
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
e99c4b7128
simplify some code
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Steffen Jaeckel
92eed34fb3
remove compat code
...
We already depend on libstrophe >= 0.12, so this code can go.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-03-11 15:05:03 +01:00
Michael Vetter
f618b9cc16
Correct ML URL in SPONSORS.md
2023-03-10 11:20:59 +01:00
Michael Vetter
96c1c44a9d
Merge pull request #1795 from IsaacM88/master
...
Fix duplicate download IDs when using "/url save"
2023-03-10 07:50:30 +01:00
IsaacM88
d043d53948
Fix duplicate download IDs.
...
Fixes https://github.com/profanity-im/profanity/issues/1794
Explanation
The problem is the download's identifier. Downloads are given an ID so they can be referenced later when their progress changes. Currently, the download's ID is the download's URL. When you download the same file twice, you have two downloads with the same ID. Download progress updates are shown on the first of both downloads with the same ID.
Solution
Change the download's ID from its URL to a random number. A random ID is generated when get_random_string() is called from cmd_funcs.c. Several other functions are updated to cope with the new ID format.
2023-03-09 15:02:26 -07:00
Michael Vetter
792be5519e
Update sponsors
...
Thanks again guys!
2023-03-01 15:35:14 +01:00
Michael Vetter
e1d45f05d3
Update to new mailing list
...
Maintained by https://github.com/StefanKropp
2023-03-01 15:25:41 +01:00
Michael Vetter
4887d21a11
cmd: Update MAM help
2023-02-15 15:40:51 +01:00
Michael Vetter
0c24271a63
Merge pull request #1789 from MarcoPolo-PasTonMolo/fix/autocompletion_after_MAM
...
Fix quote and url autocompletion for MAM and history
2023-02-15 15:18:59 +01:00
Michael Vetter
89b0744628
Merge pull request #1791 from MarcoPolo-PasTonMolo/fix/MAM_not_loading_recent_messages
...
Fix MAM not loading some recent messages
2023-02-15 15:18:08 +01:00
MarcoPolo-PasTonMolo
b64411a3f9
Fix MAM not loading some recent messages
...
Reverse a small change from commit e886ba0
that caused this issue.
Fixes https://github.com/profanity-im/profanity/issues/1790
2023-02-14 00:25:11 +02:00
MarcoPolo-PasTonMolo
6d266984a4
Fix quote and url autocompletion for MAM and history
...
After adding MAM quote and url autocompletion wouldn't pick up messages
from MAM or history(from DB) or would have them in the wrong order. This
commit fixes that.
Fixes https://github.com/profanity-im/profanity/issues/1770
2023-02-13 23:40:58 +02:00
Michael Vetter
1105571584
Merge pull request #1788 from profanity-im/minor-improvements
...
Minor improvements
2023-01-30 09:07:17 +01:00
Michael Vetter
88911c031e
Merge pull request #1786 from thexhr/devel
...
Don't pass NULL pointers to vprintf
2023-01-30 09:06:52 +01:00
Steffen Jaeckel
b602d619f6
prevent setting invalid combination of libstrophe flags
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-27 17:04:48 +01:00
the xhr
e1072c8640
Remove space to match clang coding style
2023-01-26 17:43:04 +01:00
the xhr
714add207b
Add macro for possible NULL prints and use it on known sports
...
The macro is effective on OpenBSD and basically a no op on other platforms.
Use it for one existing and the other known debug statements.
2023-01-26 17:42:52 +01:00
the xhr
6ceafac6aa
Check if string is NULL and print placeholder instead
...
OpenBSD's kernel warns about NULL printfs. Fix this with a standard check.
2023-01-26 17:39:46 +01:00
Steffen Jaeckel
901ef21727
simplify some code
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-26 11:50:02 +01:00
Steffen Jaeckel
f406384c34
fix libstrophe timer-callback usage
...
The timer will be auto-removed if the callback returns `0`. The way it was
done before breaks some internals of libstrophe.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-26 11:49:29 +01:00
Michael Vetter
494512c25c
Merge pull request #1780 from profanity-im/minor-improvements
...
Minor improvements
2023-01-19 11:05:42 +01:00
Steffen Jaeckel
99ffaf0a00
introduce auto_gcharv
...
This also fixes memory leaks in `_omemo_autocomplete()`.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-19 10:40:25 +01:00
Steffen Jaeckel
b535921484
introduce auto_jid
and refcounting in Jid
...
This also fixes a memory leak from within `_handle_groupchat()` in [0].
[0] src/xmpp/message.c
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-19 10:40:25 +01:00
Steffen Jaeckel
1a85448bf2
improve const correctness
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
e886ba0c6f
fix more memory leaks
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
698aefa005
fix memory leaks in OMEMO
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:11:13 +01:00
Steffen Jaeckel
302d0dd576
let account_new()
take ownership of passed values
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00
Steffen Jaeckel
a0aa26b6fa
add now
option to /reconnect
command
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00
Steffen Jaeckel
a45f05a45e
slightly improve command_defs[]
...
* make the struct `const`
* use designated initializers
* remove `CMD_NOxyz` macros
* fix function-pointer correctness of `sub_func[]`
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00
Steffen Jaeckel
e9aaba938b
minor changes
...
* fix typo
* less code duplication
* less `GString` usage
* more `auto_gchar` usage
* document connecting to servers supporting SASL ANONYMOUS
* ignore valgrind output
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 20:02:46 +01:00
Steffen Jaeckel
b1b6c6f62d
add /strophe
command to modify libstrophe-specific settings
...
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2023-01-18 17:04:41 +01:00
Michael Vetter
78496d6226
Merge pull request #1787 from profanity-im/fix/1695-screensaver
...
Fix xscreensaver detection
2023-01-12 07:43:07 +01:00
Paul Fertser
e19a15fd27
Fix xscreensaver detection
...
In 28a9605a1
we migrated from AC_CHECK_LIB which defines HAVE_LIBXSS automatically. With pkg-config way you need it explicit. And also x11 is needed or else linking will fail missing XFree().
Patch provided by Paul Fertser and comitted by jubalh.
Thanks Paul!
Fix https://github.com/profanity-im/profanity/issues/1695
2023-01-11 16:08:42 +01:00
Michael Vetter
3adc399da0
Update copyright year
2023-01-10 10:37:25 +01:00
Michael Vetter
0bae298746
Update mailing list link
2023-01-10 10:24:44 +01:00
Michael Vetter
c5c33bdce1
Merge pull request #1784 from MarcoPolo-PasTonMolo/fix/1783-url-save-ac-filenames
...
Make `/url save` autocomplete filenames after a url
2023-01-02 15:09:20 +01:00
Michael Vetter
9645e799ac
Remove srht ci
...
wstrm who maintains this to check our build against openbsd vanished :(
2023-01-02 14:58:25 +01:00
MarcoPolo-PasTonMolo
525ec11e46
Make /url save
autocomplete filenames after a url
...
Previously after the url if you pressed tab, even if you typed out a
filepath, profanity would erase that and cycle through url autocomplete
results.
This patch solves that and autocompletes filepaths after the url.
Fixes https://github.com/profanity-im/profanity/issues/1783
2022-12-27 14:39:31 +02:00
Michael Vetter
49ab1f3230
Merge pull request #1774 from profanity-im/fix/format
...
Work around different clang-format versions
2022-10-26 15:28:07 +02:00
Michael Vetter
413b5f9bc9
Work around different clang-format versions
...
Locally I have clang-format 15.0.2.
Our CI runs ubuntu-20.04 so it has 10.0.
Seems like a default value changed but I can't find it.
When I still had clang-format 14.x everything was fine and checking:
https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#clang-format
I only see irrelevant things.
Someone on the llvm IRC channel sais "there is no guarantee" and "maybe
a regression or intended change".
But seems like noone knows which setting could be the one we need.
Since I don't have a better solution for now I will just edit this by
hand to apply to the clang-format version we have on the CI.
Will look into updating this one.
But in any case it would be best if the configuration file could have
this setting so formatting works the same for all contributors.
2022-10-26 15:15:37 +02:00
Michael Vetter
aa9b96e25c
Merge pull request #1773 from mdosch/mam-loading-string-improvement
...
Improve MAM loading string.
2022-10-22 16:55:00 +02:00
Martin Dosch
a33d027f49
Improve MAM loading string.
...
Replaced three dots `...` by a proper ellipsis `…`.
Removed plenking (space between `messages` and ellipsis.
2022-10-22 16:09:39 +02:00
Michael Vetter
debc73c474
Merge pull request #1772 from MarcoPolo-PasTonMolo/fix/segfault-mam
...
Fix segfault when loading from MAM
2022-10-22 12:27:54 +02:00