1
0
mirror of https://github.com/profanity-im/profanity.git synced 2024-12-04 14:46:46 -05:00
Commit Graph

6748 Commits

Author SHA1 Message Date
Steffen Jaeckel
8c55294352 re-factor get_message_from_editor()
* use GLib functions to write&read compose file
* trim trailing new-line characters from compose file

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-14 15:45:01 +01:00
Steffen Jaeckel
4d71848837 replace GString usage where a simple strdup works
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-14 13:17:46 +01:00
Steffen Jaeckel
43e5f15e66 refactor logfile-name creation
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-14 13:17:46 +01:00
Steffen Jaeckel
705b6f7806 use g_mkdir_with_parents() instead of home-baked solution
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-14 13:17:46 +01:00
Steffen Jaeckel
b8e46552bf add files_file_in_account_data_path()
As all parts of the code invoking the `files_get_account_data_path()`
function did the same afterwards, a function has been added with the same
behavior.

1. create path
2. `mkdir` of that path
3. return final path

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-13 14:15:02 +01:00
Steffen Jaeckel
764a7fb71b prevent segfault
In case we're not connected yet and press Alt+c a segfault occurred
since `conn.xmpp_conn` is dereferenced while it's still `NULL`.

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-13 13:21:40 +01:00
Steffen Jaeckel
07e584734d Alt+e is already bound, use Alt+c
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-03-13 13:21:40 +01:00
Michael Vetter
9eee52d14c Correct omemo xep number in doap file 2022-03-07 19:40:08 +01:00
Michael Vetter
198ff3e9be Add stat.h to editor
Fix on openbsd:
`src/tools/editor.c:55:36: error: 'S_IRWXU' undeclared (first use in
this function)`
2022-03-04 21:09:24 +01:00
Michael Vetter
9578b03bf6 Include errno header in editor.c 2022-03-04 14:26:18 +01:00
Michael Vetter
a6dda41298
Merge pull request #1645 from MarcoPolo-PasTonMolo/feature/hotkey-send-to-editor
Add hotkey for sending readline text to editor
2022-03-03 12:57:13 +01:00
MarcoPolo-PasTonMolo
3f78af2591 Move get_message_from_editor to appropriate file and change its keybinding 2022-03-03 12:56:03 +01:00
MarcoPolo-PasTonMolo
0fdaad7cbf Add hotkey for sending readline text to editor 2022-03-03 12:55:57 +01:00
Michael Vetter
81b5230da5 Add hint about shortcuts 2022-03-02 17:24:32 +01:00
Michael Vetter
9902323943
Merge pull request #1643 from profanity-im/feat/1638-editor-subject
Add `/subject editor` command
2022-02-26 10:37:51 +01:00
Michael Vetter
b8711d5627 Add /subject editor command
Allow editing the MUC subject using external editor.

Use `/subject editor`.

Fix https://github.com/profanity-im/profanity/issues/1638
2022-02-26 10:10:33 +01:00
Michael Vetter
e96728fc66 Sort badges according to color 2022-02-24 12:07:21 +01:00
Michael Vetter
3defa56dcb Add build section to contributing.md 2022-02-23 13:14:58 +01:00
Michael Vetter
35b7555399 build: Use CPPFLAGS for obsd
Fixing build failure detected by sr.ht for OpenBSD:

```
src/ui/inputwin.c: In function '_inp_rl_startup_hook':
src/ui/inputwin.c:444:5: error: implicit declaration of function 'rl_bind_keyseq'; did you mean 'rl_bind_key'? [-Werror=implicit-function-declaration]
  444 |     rl_bind_keyseq("\\e1", _inp_rl_win_1_handler);
      |     ^~~~~~~~~~~~~~
      |     rl_bind_key
cc1: all warnings being treated as errors
```

Seems like both OSX and OpenBSD need CPPFLAGS here.
2022-02-23 12:50:03 +01:00
Michael Vetter
0b8b851bd6 Add doap to release guide 2022-02-22 16:12:10 +01:00
Michael Vetter
dc0b4b5ecf XEP-0453: add Windows 2022-02-22 15:24:14 +01:00
Michael Vetter
839d0c52fa XEP-0453: Update supported xeps
To the best of my knowledge.
Information from:
* https://profanity-im.github.io/xeps.html
* changelog
2022-02-22 15:15:22 +01:00
Stefan Kropp
bd8c32cc1e XEP-0453: DOAP usage in XMPP
Add a basic doap file.
Information taken from https://profanity-im.github.io/xeps.html.

For the most XEPs I added 'partial' as status. We should check
the status and add a note.
2022-02-22 14:41:49 +01:00
Michael Vetter
e55f6d7f4d Set libstrophe log verbosity
Set this to 0.
We might want to have this configurable later.

For now we fix the valgrind report:

```
Conditional jump or move depends on uninitialised value
xmpp_debug_verbose()
```

Which will be fixed in libstrophe > 0.11.0 by commit
28f3ce19b8
2022-02-21 21:53:33 +01:00
Michael Vetter
32f6798964 Remove link to python bug
Since 5676159aa5 the python_CPPFLAGS
isn't needed anymore. We can use python_CFLAGS.
So let's remove the comment about https://bugs.python.org/issue15018.
2022-02-18 20:16:44 +01:00
Michael Vetter
0e04439b61
Merge pull request #1642 from jugendhacker/fix/851-python-cross-compile
Fix python executed during configure
2022-02-18 20:14:56 +01:00
j.r
5676159aa5
Fix python executed during configure
Previously it relied on AX_PYTHON_DEVEL, which in turn executes
python-config to get the build flags. However this does not work while
cross compiling because we can't execute the python-config build for the
target platform. To circumvent this problem the python build flags are
now queried via pkgconfig, which has the drawback of not having some
extra build flags, but they do not seem to be needed.

I tested this patch with the termux build system and it build without
their existing hack of injecting python after the configure step. I also
tested non cross compile build on Arch Linux and it also still works.

Fixes #851
2022-02-18 19:45:31 +01:00
Michael Vetter
57fb10f0bf Fix typos in comments 2022-02-18 18:59:32 +01:00
Michael Vetter
d15f905d83 Add unit tests section to CONTIBUTING.md
And rename a header.
2022-02-18 18:49:43 +01:00
Michael Vetter
fc1a24b9fa Add Pull Request template 2022-02-18 18:11:51 +01:00
Michael Vetter
5957b757ce
Merge pull request #1641 from profanity-im/clean-configure
Clean up configure.ac
2022-02-18 18:09:37 +01:00
Michael Vetter
9a8e220770 Remove configure-plugins helper script
We don't really need this.
2022-02-18 17:57:08 +01:00
Michael Vetter
fc13a69f43 build: use target instead of host
If I understand https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Canonicalizing.html
correctly then we should use target and not host.

Will only matter in case of crosscompiling.
2022-02-18 17:36:03 +01:00
Michael Vetter
28a9605a1f build: use PKG_CHECK_MODULES to check for xscreensaver 2022-02-18 17:35:30 +01:00
Michael Vetter
38ff3699b4 build: use CFLAGS instead of CPPFLAGS where possible
OSX seems to need CPPFLAGS for readline.
2022-02-18 15:07:27 +01:00
Michael Vetter
33106ecf9c build: remove otr3 support
All the distributions I checked have libotr 4.1.1 now.
2022-02-18 14:01:28 +01:00
Michael Vetter
3f8720d70f build: remove support for old libsignal
Remove support for libsignal-protocol-c < 2.3.2.
Debian 10 uses 2.3.2, Debian 11 and 12 use 2.3.3.
openSUSE from 15.2 onward uses 2.3.3.
Fedora since 28 uses 2.3.2.

We should be good.
2022-02-18 14:01:28 +01:00
Michael Vetter
1856c1e7fc build: remove xmpp_lib variable
Since cad934b9a0 we only support
libstrophe. libmesode is deprecated.
2022-02-18 14:01:28 +01:00
Michael Vetter
7a6a37e717 build: group related parts better together 2022-02-18 14:01:27 +01:00
Michael Vetter
9cb6fc0d23 build: change comments 2022-02-18 14:00:13 +01:00
Michael Vetter
c79ba8f80e build: define min autotools version and set url 2022-02-18 13:59:14 +01:00
Michael Vetter
201ef7394a build: use AC_MSG_NOTICE instead of echo 2022-02-18 13:54:49 +01:00
Michael Vetter
adc68bd4b1 build: add vim modeline 2022-02-17 15:48:56 +01:00
Michael Vetter
7bbaa11a54
Merge pull request #1640 from profanity-im/contributing-rules
Update the contributing guide
2022-02-17 14:28:49 +01:00
Michael Vetter
a9c875e2ce Update the contributing guide
We need to define some rules to make sure people know what they need to
take care about.
To allow us to later still understand the changes in an optimal way and
make everyones work easier.
2022-02-17 14:02:45 +01:00
Michael Vetter
7500100a5b Remove Patreon 2022-02-16 12:21:18 +01:00
Michael Vetter
186a8b25a0
Merge pull request #1637 from profanity-im/fix-soh-regression
fix handling of connection errors
2022-02-14 11:31:49 +01:00
Steffen Jaeckel
7a2af5e3ad fix handling of connection errors
When a `see-other-host` stream-error is received we try to re-connect to
the other host. Erroneously this also started the `reconnect_timer`.
This lead to the behavior that in cases where e.g. the login failed
we try to reconnect instead of bailing out with an error.

This commit fixes the wrong behavior by not starting the `reconnect_timer`.

Fix 0e58509c16

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
2022-02-08 19:52:13 +01:00
Michael Vetter
fb91824883
Merge pull request #1635 from arya-pratap-singh/master
Fix typo in comment from "the YES" to "to YES"
2022-02-03 14:11:15 +01:00
arya-pratap-singh
71ac7478ae fixed typo from "the Yes" to "to YES" 2022-02-03 14:25:25 +05:30