From dc43cc602c461ce449af1d428404150eeab8cb24 Mon Sep 17 00:00:00 2001 From: Will Song Date: Wed, 14 Jan 2015 11:10:14 -0600 Subject: [PATCH] fix yet another potential leak --- src/command/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/command/commands.c b/src/command/commands.c index 9fd6eed4..2a22f323 100644 --- a/src/command/commands.c +++ b/src/command/commands.c @@ -138,6 +138,7 @@ cmd_connect(gchar **args, struct cmd_help_t help) // Evaluate as shell command to retrieve password GString *cmd = g_string_append(g_string_new(account->eval_password), " 2>/dev/null"); FILE *stream = popen(cmd->str, "r"); + g_string_free(cmd, TRUE); if(stream){ // Limit to READ_BUF_SIZE bytes to prevent overflows in the case of a poorly chosen command account->password = g_malloc(READ_BUF_SIZE); @@ -158,7 +159,6 @@ cmd_connect(gchar **args, struct cmd_help_t help) cons_show("Error evaluating password, see logs for details."); return TRUE; } - g_string_free(cmd, TRUE); } else if (!account->password) { account->password = ui_ask_password(); }