aniani/profanity
1
1
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2025-02-02 15:08:15 -05:00
Code

ox: fix mistakes in p_ox_gpg_decrypt()

Browse Source 
strcpy() can't work here because the data doesn't have to be
NULL-terminated. So let's use memcpy.

Fix memleak of plain_str.
This commit is contained in:
Michael Vetter 2022-05-04 11:35:15 +02:00
parent 281c8b7d8d
commit e5e661e92d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pgp/gpg.c
View File

@ -1195,11 +1195,13 @@ p_ox_gpg_decrypt(char* base64)
return NULL; return NULL;
} }
} }
size_t len; size_t len;
char* plain_str = gpgme_data_release_and_get_mem(plain, &len); char* plain_str = gpgme_data_release_and_get_mem(plain, &len);
char* result = malloc(len + 1); char* result = malloc(len + 1);
strcpy(result, plain_str); memcpy(result, plain_str, len);
result[len] = '\0'; result[len] = '\0';
gpgme_free(plain_str);
return result; return result;
} }