aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2025-01-03 14:57:42 -05:00
Code

Merge pull request #1309 from profanity-im/use-after-free

Browse Source 
Fix use-after-free in stanza_create_caps_from_query_element()
This commit is contained in:
Michael Vetter 2020-04-10 14:02:50 +02:00 committed by GitHub
commit e1b8fb24c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/xmpp/stanza.c
View File

@ -1784,13 +1784,13 @@ stanza_create_caps_from_query_element(xmpp_stanza_t *query)
formField = field->data;
if (formField->values) {
if (strcmp(formField->var, "software") == 0) {
software = formField->values->data;
software = strdup(formField->values->data);
} else if (strcmp(formField->var, "software_version") == 0) {
software_version = formField->values->data;
software_version = strdup(formField->values->data);
} else if (strcmp(formField->var, "os") == 0) {
os = formField->values->data;
os = strdup(formField->values->data);
} else if (strcmp(formField->var, "os_version") == 0) {
os_version = formField->values->data;
os_version = strdup(formField->values->data);
}
}
field = g_slist_next(field);
@ -1872,6 +1872,10 @@ stanza_create_caps_from_query_element(xmpp_stanza_t *query)
EntityCapabilities *result = caps_create(category, type, name, software, software_version, os, os_version, features);
g_slist_free_full(features, free);
free(software);
free(software_version);
free(os);
free(os_version);
return result;
}