aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2024-11-03 19:37:16 -05:00
Code

Free GError objects

Browse Source 
glib functions can allocate a GError object that must be freed with
g_error_free(). Otherwise a memory leak happens.

There are similar unfixed places in omemo, check:
    grep "&error" src/omemo/omemo.c

Fixes #1304.
This commit is contained in:
Dmitry Podgorny 2020-04-14 03:24:02 +03:00
parent a42c2a1134
commit b3eea13125
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common.c
View File

@ -114,6 +114,8 @@ copy_file(const char *const sourcepath, const char *const targetpath, const gboo
GError *error = NULL; GError *error = NULL;
GFileCopyFlags flags = overwrite_existing ? G_FILE_COPY_OVERWRITE : G_FILE_COPY_NONE; GFileCopyFlags flags = overwrite_existing ? G_FILE_COPY_OVERWRITE : G_FILE_COPY_NONE;
gboolean success = g_file_copy (source, dest, flags, NULL, NULL, NULL, &error); gboolean success = g_file_copy (source, dest, flags, NULL, NULL, NULL, &error);
if (error != NULL)
g_error_free(error);
g_object_unref(source); g_object_unref(source);
g_object_unref(dest); g_object_unref(dest);
return success; return success;

5
src/ui/notifier.c
View File

@ -224,9 +224,10 @@ notify(const char *const message, int timeout, const char *const category)
log_error("Error sending desktop notification:"); log_error("Error sending desktop notification:");
log_error(" -> Message : %s", message); log_error(" -> Message : %s", message);
log_error(" -> Error : %s", error->message); log_error(" -> Error : %s", error->message);
g_error_free(error);
} else { } else {
log_debug("Notification sent."); log_debug("Notification sent.");
} }
} else { } else {
log_error("Libnotify not initialised."); log_error("Libnotify not initialised.");
} }