aniani/profanity
1
0
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2025-01-03 14:57:42 -05:00
Code

Added invalid jid test for /join

Browse Source
This commit is contained in:
James Booth 2014-03-08 00:23:52 +00:00
parent 2d54c565ce
commit a94814f0a9
4 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/command/commands.c
View File

@ -1591,7 +1591,8 @@ cmd_join(gchar **args, struct cmd_help_t help)
Jid *room_arg = jid_create(args[0]);
if (room_arg == NULL) {
cons_show_error("Specified room has incorrect format");
cons_show_error("Specified room has incorrect format.");
cons_show("");
return TRUE;
}

17
tests/test_cmd_join.c
View File

@ -67,6 +67,23 @@ void cmd_join_shows_usage_when_no_args(void **state)
free(help);
}
void cmd_join_shows_error_message_when_invalid_room_jid(void **state)
{
mock_cons_show_error();
CommandHelp *help = malloc(sizeof(CommandHelp));
gchar *args[] = { "//@@/", NULL };
mock_connection_status(JABBER_CONNECTED);
expect_cons_show_error("Specified room has incorrect format.");
expect_cons_show("");
gboolean result = cmd_join(args, *help);
assert_true(result);
free(help);
}
/*
void cmd_connect_shows_usage_when_no_server_value(void **state)
{

1
tests/test_cmd_join.h
View File

@ -3,3 +3,4 @@ void cmd_join_shows_message_when_connecting(void **state);
void cmd_join_shows_message_when_disconnected(void **state);
void cmd_join_shows_message_when_undefined(void **state);
void cmd_join_shows_usage_when_no_args(void **state);
void cmd_join_shows_error_message_when_invalid_room_jid(void **state);

1
tests/testsuite.c
View File

@ -492,6 +492,7 @@ int main(int argc, char* argv[]) {
unit_test(cmd_join_shows_message_when_disconnected),
unit_test(cmd_join_shows_message_when_undefined),
unit_test(cmd_join_shows_usage_when_no_args),
unit_test(cmd_join_shows_error_message_when_invalid_room_jid),
};
return run_tests(all_tests);