From 9bb2d7f95e12b5a2ce6a957c92efaa6a4171e663 Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Thu, 12 Dec 2019 22:24:09 +0100 Subject: [PATCH] Dont print error message if a valid setting function is called This is because the actual command that parses itself (cmd_logging) returns false if it didn't get the expected parameters. Handing the printing however is done by another function. This function is added to the Command struct as setting_function. So if this is set, and the actual command returns false. We should just call the setting_function and not print the error message. Fix https://github.com/profanity-im/profanity/issues/1237 --- src/ui/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ui/core.c b/src/ui/core.c index 2bc03b27..8c7eca2e 100644 --- a/src/ui/core.c +++ b/src/ui/core.c @@ -462,7 +462,6 @@ ui_invalid_command_usage(const char *const cmd, void (*setting_func)(void)) if (setting_func) { cons_show(""); (*setting_func)(); - cons_show(msg->str); } else { cons_show(""); cons_show(msg->str);