From 899b26b3bce7bc7575be79df0cb9462c9e17623a Mon Sep 17 00:00:00 2001 From: John Hernandez <129467592+H3rnand3zzz@users.noreply.github.com> Date: Thu, 13 Apr 2023 15:26:19 +0200 Subject: [PATCH] Cleanup p_ox_gpg_decrypt In OX implementation gpgme's buffer remains untouched, thus not leading to the crash. But code can be shorter and more concise. --- src/pgp/ox.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/pgp/ox.c b/src/pgp/ox.c index 71fa6c8c..4d42a2a7 100644 --- a/src/pgp/ox.c +++ b/src/pgp/ox.c @@ -419,10 +419,12 @@ p_ox_gpg_decrypt(char* base64) size_t len; char* plain_str = gpgme_data_release_and_get_mem(plain, &len); - char* result = malloc(len + 1); - memcpy(result, plain_str, len); - result[len] = '\0'; - gpgme_free(plain_str); + char* result = NULL; + if (plain_str) { + result = strndup(plain_str, len); + gpgme_free(plain_str); + } + return result; }