aniani/profanity
1
1
Fork 0
mirror of https://github.com/profanity-im/profanity.git synced 2025-01-03 14:57:42 -05:00
Code

Merge pull request #1924 from H3rnand3zzz/fix/unintended-exits

Browse Source 
Fix unintended exits on some commands
This commit is contained in:
Michael Vetter 2023-11-14 12:49:42 +01:00 committed by GitHub
commit 7718990c08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/command/cmd_funcs.c
View File

@ -5543,7 +5543,7 @@ gboolean
cmd_states(ProfWin* window, const char* const command, gchar** args) cmd_states(ProfWin* window, const char* const command, gchar** args)
{ {
if (args[0] == NULL) { if (args[0] == NULL) {
return FALSE; return TRUE;
} }
_cmd_set_boolean_preference(args[0], "Sending chat states", PREF_STATES); _cmd_set_boolean_preference(args[0], "Sending chat states", PREF_STATES);
@ -5580,7 +5580,7 @@ gboolean
cmd_outtype(ProfWin* window, const char* const command, gchar** args) cmd_outtype(ProfWin* window, const char* const command, gchar** args)
{ {
if (args[0] == NULL) { if (args[0] == NULL) {
return FALSE; return TRUE;
} }
_cmd_set_boolean_preference(args[0], "Sending typing notifications", PREF_OUTTYPE); _cmd_set_boolean_preference(args[0], "Sending typing notifications", PREF_OUTTYPE);
@ -6837,14 +6837,14 @@ cmd_privacy(ProfWin* window, const char* const command, gchar** args)
{ {
if (args[0] == NULL) { if (args[0] == NULL) {
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
return FALSE; return TRUE;
} }
if (g_strcmp0(args[0], "logging") == 0) { if (g_strcmp0(args[0], "logging") == 0) {
gchar* arg = args[1]; gchar* arg = args[1];
if (arg == NULL) { if (arg == NULL) {
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
return FALSE; return TRUE;
} }
if (g_strcmp0(arg, "on") == 0) { if (g_strcmp0(arg, "on") == 0) {
@ -6862,7 +6862,7 @@ cmd_privacy(ProfWin* window, const char* const command, gchar** args)
prefs_set_string(PREF_DBLOG, arg); prefs_set_string(PREF_DBLOG, arg);
} else { } else {
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
return FALSE; return TRUE;
} }
return TRUE; return TRUE;
} }
@ -6888,7 +6888,8 @@ cmd_logging(ProfWin* window, const char* const command, gchar** args)
return TRUE; return TRUE;
} else if (g_strcmp0(args[0], "group") == 0 && args[1] != NULL) { } else if (g_strcmp0(args[0], "group") == 0 && args[1] != NULL) {
return _cmd_set_boolean_preference(args[1], "Groupchat logging", PREF_GRLOG); _cmd_set_boolean_preference(args[1], "Groupchat logging", PREF_GRLOG);
return TRUE;
} }
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
@ -6899,7 +6900,8 @@ gboolean
cmd_history(ProfWin* window, const char* const command, gchar** args) cmd_history(ProfWin* window, const char* const command, gchar** args)
{ {
if (args[0] == NULL) { if (args[0] == NULL) {
return FALSE; cons_bad_cmd_usage(command);
return TRUE;
} }
_cmd_set_boolean_preference(args[0], "Chat history", PREF_HISTORY); _cmd_set_boolean_preference(args[0], "Chat history", PREF_HISTORY);
@ -6916,7 +6918,8 @@ gboolean
cmd_carbons(ProfWin* window, const char* const command, gchar** args) cmd_carbons(ProfWin* window, const char* const command, gchar** args)
{ {
if (args[0] == NULL) { if (args[0] == NULL) {
return FALSE; cons_bad_cmd_usage(command);
return TRUE;
} }
_cmd_set_boolean_preference(args[0], "Message carbons preference", PREF_CARBONS); _cmd_set_boolean_preference(args[0], "Message carbons preference", PREF_CARBONS);
@ -9854,7 +9857,7 @@ cmd_strophe(ProfWin* window, const char* const command, gchar** args)
} }
} }
cons_bad_cmd_usage(command); cons_bad_cmd_usage(command);
return FALSE; return TRUE;
} }
gboolean gboolean