Moved error handling logic to server_events

src/server_events.c

@@ -37,6 +37,7 @@
 #include "otr.h"
 #endif
 
+// TODO - replace with stanza error handlers
 void
 handle_error_message(const char *from, const char *err_msg)
 {
@@ -52,27 +53,28 @@ handle_error_message(const char *from, const char *err_msg)
     }
 }
 
+// handle message stanza errors
 void
-handle_recipient_not_found(const char * const recipient, const char * const err_msg)
+handle_message_error(const char * const from, const char * const type,
+    const char * const err_msg)
 {
-    ui_handle_recipient_not_found(recipient, err_msg);
-    if (prefs_get_boolean(PREF_STATES) && chat_session_exists(recipient)) {
-        chat_session_set_recipient_supports(recipient, FALSE);
+    // handle recipient not found ('from' contains a value and type is 'cancel')
+    if ((from != NULL) && ((type != NULL && (strcmp(type, "cancel") == 0)))) {
+        ui_handle_recipient_not_found(from, err_msg);
+        if (prefs_get_boolean(PREF_STATES) && chat_session_exists(from)) {
+            chat_session_set_recipient_supports(from, FALSE);
+        }
+
+    // handle any other error from recipient
+    } else if (from != NULL) {
+        ui_handle_recipient_error(from, err_msg);
+
+    // handle errors from no recipient
+    } else {
+        ui_handle_error(err_msg);
     }
 }
 
-void
-handle_recipient_error(const char * const recipient, const char * const err_msg)
-{
-    ui_handle_recipient_error(recipient, err_msg);
-}
-
-void
-handle_error(const char * const err_msg)
-{
-    ui_handle_error(err_msg);
-}
-
 void
 handle_login_account_success(char *account_name)
 {

src/server_events.h

@@ -75,8 +75,7 @@ void handle_group_remove(const char * const contact,
 void handle_roster_remove(const char * const barejid);
 void handle_roster_add(const char * const barejid, const char * const name);
 void handle_autoping_cancel(void);
-void handle_recipient_not_found(const char * const recipient, const char * const err_msg);
-void handle_recipient_error(const char * const recipient, const char * const err_msg);
-void handle_error(const char * const err_msg);
+void handle_message_error(const char * const from, const char * const type,
+    const char * const err_msg);
 
 #endif

src/xmpp/message.c

@@ -224,18 +224,7 @@ _message_error_handler(xmpp_conn_t * const conn, xmpp_stanza_t * const stanza,
 
     g_string_free(log_msg, TRUE);
 
-    // handle recipient not found ('from' contains a value and type is 'cancel')
-    if ((from != NULL) && ((type != NULL && (strcmp(type, "cancel") == 0)))) {
-        handle_recipient_not_found(from, err_msg);
-
-    // handle any other error from recipient
-    } else if (from != NULL) {
-        handle_recipient_error(from, err_msg);
-
-    // handle errors from no recipient
-    } else {
-        handle_error(err_msg);
-    }
+    handle_message_error(from, type, err_msg);
 
     free(err_msg);
 

tests/test_server_events.c

@@ -104,3 +104,12 @@ void console_shows_dnd_presence_when_set_all(void **state)
 
     roster_clear();
 }
+
+void handle_message_stanza_error_when_no_from(void **state)
+{
+    char *err_msg = "Some error.";
+    mock_ui_handle_error();
+    expect_ui_handle_error(err_msg);
+
+    handle_message_error(NULL, "cancel", err_msg);
+}

tests/test_server_events.h

@@ -4,3 +4,4 @@ void console_shows_online_presence_when_set_all(void **state);
 void console_doesnt_show_dnd_presence_when_set_none(void **state);
 void console_doesnt_show_dnd_presence_when_set_online(void **state);
 void console_shows_dnd_presence_when_set_all(void **state);
+void handle_message_stanza_error_when_no_from(void **state);

tests/testsuite.c

@@ -389,6 +389,7 @@ int main(int argc, char* argv[]) {
         unit_test_setup_teardown(console_shows_dnd_presence_when_set_all,
             init_preferences,
             close_preferences),
+        unit_test(handle_message_stanza_error_when_no_from)
     };
 
     const UnitTest cmd_alias_tests[] = {

tests/ui/mock_ui.c

@@ -92,6 +92,12 @@ char * _stub_ui_ask_password(void)
     return NULL;
 }
 
+static
+void _mock_ui_handle_error(const char * const err_msg)
+{
+    check_expected(err_msg);
+}
+
 static
 void _stub_ui_chat_win_contact_online(PContact contact, Resource *resource, GDateTime *last_activity)
 {
@@ -159,6 +165,12 @@ stub_cons_show(void)
     cons_show = _stub_cons_show;
 }
 
+void
+mock_ui_handle_error(void)
+{
+    ui_handle_error = _mock_ui_handle_error;
+}
+
 void
 expect_cons_show(char *output)
 {
@@ -213,3 +225,9 @@ mock_ui_ask_password_returns(char *password)
 {
     will_return(_mock_ui_ask_password, strdup(password));
 }
+
+void
+expect_ui_handle_error(char *err_msg)
+{
+    expect_string(_mock_ui_handle_error, err_msg, err_msg);
+}

tests/ui/mock_ui.h

@@ -18,6 +18,9 @@ void stub_ui_chat_win_contact_online(void);
 void mock_cons_show_error(void);
 void expect_cons_show_error(char *output);
 
+void mock_ui_handle_error(void);
+void expect_ui_handle_error(char *err_msg);
+
 void mock_cons_show_account(void);
 void expect_cons_show_account(ProfAccount *account);