1
0
mirror of https://github.com/irssi/irssi.git synced 2024-09-15 04:28:09 -04:00

Merge branch 'fix-11' into 'security'

Correct GHashTable usage

See merge request !16
This commit is contained in:
Nei 2017-07-05 14:46:42 +00:00
commit f67e766934

View File

@ -54,23 +54,26 @@ static void nick_hash_add(CHANNEL_REC *channel, NICK_REC *nick)
static void nick_hash_remove(CHANNEL_REC *channel, NICK_REC *nick) static void nick_hash_remove(CHANNEL_REC *channel, NICK_REC *nick)
{ {
NICK_REC *list; NICK_REC *list, *newlist;
list = g_hash_table_lookup(channel->nicks, nick->nick); list = g_hash_table_lookup(channel->nicks, nick->nick);
if (list == NULL) if (list == NULL)
return; return;
if (list == nick || list->next == NULL) { if (list == nick) {
g_hash_table_remove(channel->nicks, nick->nick); newlist = nick->next;
if (list->next != NULL) {
g_hash_table_insert(channel->nicks, nick->next->nick,
nick->next);
}
} else { } else {
newlist = list;
while (list->next != nick) while (list->next != nick)
list = list->next; list = list->next;
list->next = nick->next; list->next = nick->next;
} }
g_hash_table_remove(channel->nicks, nick->nick);
if (newlist != NULL) {
g_hash_table_insert(channel->nicks, newlist->nick,
newlist);
}
} }
/* Add new nick to list */ /* Add new nick to list */