aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2025-02-02 15:08:01 -05:00
Code

Make a copy of the signal arguments so we don't have to worry about the stack

Browse Source 
plug some mem leaks

later copy
This commit is contained in:
Ailin Nemui 2020-11-11 23:06:59 +01:00
parent 5f7d274ec5
commit c9ccf9867f
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/perl/perl-signals.c
View File

@ -87,8 +87,9 @@ void perl_signal_args_to_c(void (*callback)(void *, int, void **), void *cb_arg,
GSList *v_gslist; GSList *v_gslist;
GList *v_glist; GList *v_glist;
} saved_args[SIGNAL_MAX_ARGUMENTS]; } saved_args[SIGNAL_MAX_ARGUMENTS];
void *p[SIGNAL_MAX_ARGUMENTS]; AV *aargs;
PERL_SIGNAL_ARGS_REC *rec; void *p[SIGNAL_MAX_ARGUMENTS];
PERL_SIGNAL_ARGS_REC *rec;
char *arglist[MAX_FORMAT_PARAMS]; char *arglist[MAX_FORMAT_PARAMS];
size_t n; size_t n;
@ -203,10 +204,13 @@ void perl_signal_args_to_c(void (*callback)(void *, int, void **), void *cb_arg,
p[n] = NULL; p[n] = NULL;
} }
/* make a copy of the stack now, since the callback might change it */
aargs = av_make(n_args, args);
callback(cb_arg, n_args, p); callback(cb_arg, n_args, p);
for (n = 0; n < SIGNAL_MAX_ARGUMENTS && n < n_args && rec->args[n] != NULL; ++n) { for (n = 0; n < SIGNAL_MAX_ARGUMENTS && n < n_args && rec->args[n] != NULL; ++n) {
SV *arg = args[n]; SV *arg = *av_fetch(aargs, n, 0);
if (!SvOK(arg)) { if (!SvOK(arg)) {
continue; continue;
@ -245,6 +249,7 @@ void perl_signal_args_to_c(void (*callback)(void *, int, void **), void *cb_arg,
g_list_free(gl); g_list_free(gl);
} }
} }
av_undef(aargs);
} }
static void perl_call_signal(PERL_SCRIPT_REC *script, SV *func, static void perl_call_signal(PERL_SCRIPT_REC *script, SV *func,