aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2024-11-03 04:27:19 -05:00
Code

Prevent a UaF by calling server_disconnect in a signal handler.

Browse Source
This commit is contained in:
LemonBoy 2016-12-15 22:41:57 +01:00
parent 4ccffd85ff
commit 7a7f6abc16
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/fe-common/irc/fe-sasl.c
View File

@ -43,8 +43,15 @@ static void sig_cap_end(IRC_SERVER_REC *server)
/* The negotiation has now been terminated, if we didn't manage to
* authenticate successfully with the server just disconnect. */
if (!server->sasl_success &&
settings_get_bool("sasl_disconnect_on_failure"))
server_disconnect(SERVER(server));
settings_get_bool("sasl_disconnect_on_failure")) {
/* We can't use server_disconnect() here because we'd end up
* freeing the 'server' object and be guilty of a slew of UaF. */
server->connection_lost = TRUE;
/* By setting connection_lost we make sure the communication is
* halted and when the control goes back to irc_parse_incoming
* the server object is safely destroyed. */
signal_stop();
}
}