aniani/irssi
1
0
Fork 0
mirror of https://github.com/irssi/irssi.git synced 2024-09-01 04:14:16 -04:00
Code

Always initialize the host string

Browse Source 
This also removes a wordy comment
This commit is contained in:
Will Storey 2017-10-10 18:21:05 -07:00
parent 4ccff71f67
commit 174adee9dd
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/network.c
View File

@ -489,16 +489,8 @@ int net_gethostbyaddr(IPADDR *ip, char **name)
int net_ip2host(IPADDR *ip, char *host)
{
if (inet_ntop(ip->family, &ip->ip, host, MAX_IP_LEN)) {
return 0;
}
// For callers that do not check our return value and pass in an
// uninitialized buffer assuming it will be set, ensure the buffer is a valid
// string. Ideally callers should check what we return and handle
// appropriately, but this at least gives us safety.
host[0] = '\0';
return -1;
return inet_ntop(ip->family, &ip->ip, host, MAX_IP_LEN) ? 0 : -1;
}
int net_host2ip(const char *host, IPADDR *ip)