From d1ea95f0e5839e22070cf3d1279f103a0734e1c5 Mon Sep 17 00:00:00 2001
From: Philipp Schafft <lion@lion.leolix.org>
Date: Sat, 12 Mar 2022 12:51:29 +0000
Subject: [PATCH] Fix: Updated default config and parsing to reflect existance
 of <tls-context>

---
 conf/icecast.xml.in | 15 +++++++++++----
 src/cfgfile.c       | 11 +++++++++++
 2 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/conf/icecast.xml.in b/conf/icecast.xml.in
index a4e58b25..d00d4cbf 100644
--- a/conf/icecast.xml.in
+++ b/conf/icecast.xml.in
@@ -282,10 +282,6 @@
              the status page
         -->
         <alias source="/" destination="/status.xsl"/>
-        <!-- The certificate file needs to contain both public and private part.
-             Both should be PEM encoded.
-        <tls-certificate>@pkgdatadir@/icecast.pem</tls-certificate>
-        -->
     </paths>
 
     <logging>
@@ -311,6 +307,17 @@
         </changeowner>
         -->
 
+        <tls-context>
+            <!-- The certificate file containng public and optionally private key.
+                Must be PEM encoded.
+                <tls-certificate>@pkgdatadir@/icecast.pem</tls-certificate>
+            -->
+            <!-- The private key if not contained in <tls-certificate>.
+                Must be PEM encoded.
+                <tls-key>@pkgdatadir@/icecast.key</tls-key>
+            -->
+        </tls-context>
+
         <!-- It is generally helpful to set a PRNG seed, what seed to set depends on your OS. -->
         <!-- Useful on all operating systems is a seed file for Icecast to update.
              This should be at some location that is (semi-)permanent such as /var/lib or /var/cache
diff --git a/src/cfgfile.c b/src/cfgfile.c
index 993975c8..99d68815 100644
--- a/src/cfgfile.c
+++ b/src/cfgfile.c
@@ -2625,8 +2625,12 @@ static void _parse_paths(xmlDocPtr      doc,
             configuration->allowfile = (char *)xmlNodeListGetString(doc, node->xmlChildrenNode, 1);
         } else if (xmlStrcmp(node->name, XMLSTR("tls-certificate")) == 0 ||
                    xmlStrcmp(node->name, XMLSTR("ssl-certificate")) == 0) {
+
+            __found_bad_tag(configuration, node, BTR_OBSOLETE, "Use a <tls-certificate> in <tls-context>.");
+
             if (__check_node_impl(node, "generic") != 0) {
                 ICECAST_LOG_WARN("Node %s uses unsupported implementation.", node->name);
+                __found_bad_tag(configuration, node, BTR_INVALID, NULL);
                 continue;
             }
 
@@ -2635,8 +2639,12 @@ static void _parse_paths(xmlDocPtr      doc,
             configuration->tls_context.cert_file = (char *)xmlNodeListGetString(doc, node->xmlChildrenNode, 1);
         } else if (xmlStrcmp(node->name, XMLSTR("tls-allowed-ciphers")) == 0 ||
                    xmlStrcmp(node->name, XMLSTR("ssl-allowed-ciphers")) == 0) {
+
+            __found_bad_tag(configuration, node, BTR_OBSOLETE, "Use a <tls-allowed-cipherse> in <tls-context>.");
+
             if (__check_node_impl(node, "openssl") != 0) {
                 ICECAST_LOG_WARN("Node %s uses unsupported implementation.", node->name);
+                __found_bad_tag(configuration, node, BTR_INVALID, NULL);
                 continue;
             }
 
@@ -2785,6 +2793,7 @@ static void _parse_tls_context(xmlDocPtr       doc,
         if (xmlStrcmp(node->name, XMLSTR("tls-certificate")) == 0) {
             if (__check_node_impl(node, "generic") != 0) {
                 ICECAST_LOG_WARN("Node %s uses unsupported implementation.", node->name);
+                __found_bad_tag(configuration, node, BTR_INVALID, NULL);
                 continue;
             }
 
@@ -2794,6 +2803,7 @@ static void _parse_tls_context(xmlDocPtr       doc,
         } else if (xmlStrcmp(node->name, XMLSTR("tls-key")) == 0) {
             if (__check_node_impl(node, "generic") != 0) {
                 ICECAST_LOG_WARN("Node %s uses unsupported implementation.", node->name);
+                __found_bad_tag(configuration, node, BTR_INVALID, NULL);
                 continue;
             }
 
@@ -2803,6 +2813,7 @@ static void _parse_tls_context(xmlDocPtr       doc,
         } else if (xmlStrcmp(node->name, XMLSTR("tls-allowed-ciphers")) == 0) {
             if (__check_node_impl(node, "openssl") != 0) {
                 ICECAST_LOG_WARN("Node %s uses unsupported implementation.", node->name);
+                __found_bad_tag(configuration, node, BTR_INVALID, NULL);
                 continue;
             }