mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-28 08:07:48 -04:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			332 lines
		
	
	
		
			8.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			332 lines
		
	
	
		
			8.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package repo
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/modules/context"
 | |
| 	"code.gitea.io/gitea/modules/convert"
 | |
| 	"code.gitea.io/gitea/modules/log"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/modules/upload"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| )
 | |
| 
 | |
| // GetReleaseAttachment gets a single attachment of the release
 | |
| func GetReleaseAttachment(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /repos/{owner}/{repo}/releases/{id}/assets/{attachment_id} repository repoGetReleaseAttachment
 | |
| 	// ---
 | |
| 	// summary: Get a release attachment
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the release
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: attachment_id
 | |
| 	//   in: path
 | |
| 	//   description: id of the attachment to get
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Attachment"
 | |
| 
 | |
| 	releaseID := ctx.ParamsInt64(":id")
 | |
| 	attachID := ctx.ParamsInt64(":asset")
 | |
| 	attach, err := models.GetAttachmentByID(attachID)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetAttachmentByID", err)
 | |
| 		return
 | |
| 	}
 | |
| 	if attach.ReleaseID != releaseID {
 | |
| 		log.Info("User requested attachment is not in release, release_id %v, attachment_id: %v", releaseID, attachID)
 | |
| 		ctx.NotFound()
 | |
| 		return
 | |
| 	}
 | |
| 	// FIXME Should prove the existence of the given repo, but results in unnecessary database requests
 | |
| 	ctx.JSON(http.StatusOK, convert.ToReleaseAttachment(attach))
 | |
| }
 | |
| 
 | |
| // ListReleaseAttachments lists all attachments of the release
 | |
| func ListReleaseAttachments(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /repos/{owner}/{repo}/releases/{id}/assets repository repoListReleaseAttachments
 | |
| 	// ---
 | |
| 	// summary: List release's attachments
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the release
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/AttachmentList"
 | |
| 
 | |
| 	releaseID := ctx.ParamsInt64(":id")
 | |
| 	release, err := models.GetReleaseByID(releaseID)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetReleaseByID", err)
 | |
| 		return
 | |
| 	}
 | |
| 	if release.RepoID != ctx.Repo.Repository.ID {
 | |
| 		ctx.NotFound()
 | |
| 		return
 | |
| 	}
 | |
| 	if err := release.LoadAttributes(); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "LoadAttributes", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, convert.ToRelease(release).Attachments)
 | |
| }
 | |
| 
 | |
| // CreateReleaseAttachment creates an attachment and saves the given file
 | |
| func CreateReleaseAttachment(ctx *context.APIContext) {
 | |
| 	// swagger:operation POST /repos/{owner}/{repo}/releases/{id}/assets repository repoCreateReleaseAttachment
 | |
| 	// ---
 | |
| 	// summary: Create a release attachment
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// consumes:
 | |
| 	// - multipart/form-data
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the release
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: name
 | |
| 	//   in: query
 | |
| 	//   description: name of the attachment
 | |
| 	//   type: string
 | |
| 	//   required: false
 | |
| 	// - name: attachment
 | |
| 	//   in: formData
 | |
| 	//   description: attachment to upload
 | |
| 	//   type: file
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "201":
 | |
| 	//     "$ref": "#/responses/Attachment"
 | |
| 	//   "400":
 | |
| 	//     "$ref": "#/responses/error"
 | |
| 
 | |
| 	// Check if attachments are enabled
 | |
| 	if !setting.Attachment.Enabled {
 | |
| 		ctx.NotFound("Attachment is not enabled")
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Check if release exists an load release
 | |
| 	releaseID := ctx.ParamsInt64(":id")
 | |
| 	release, err := models.GetReleaseByID(releaseID)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetReleaseByID", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Get uploaded file from request
 | |
| 	file, header, err := ctx.Req.FormFile("attachment")
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetFile", err)
 | |
| 		return
 | |
| 	}
 | |
| 	defer file.Close()
 | |
| 
 | |
| 	buf := make([]byte, 1024)
 | |
| 	n, _ := file.Read(buf)
 | |
| 	if n > 0 {
 | |
| 		buf = buf[:n]
 | |
| 	}
 | |
| 
 | |
| 	// Check if the filetype is allowed by the settings
 | |
| 	err = upload.Verify(buf, header.Filename, setting.Repository.Release.AllowedTypes)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusBadRequest, "DetectContentType", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	var filename = header.Filename
 | |
| 	if query := ctx.Query("name"); query != "" {
 | |
| 		filename = query
 | |
| 	}
 | |
| 
 | |
| 	// Create a new attachment and save the file
 | |
| 	attach, err := models.NewAttachment(&models.Attachment{
 | |
| 		UploaderID: ctx.User.ID,
 | |
| 		Name:       filename,
 | |
| 		ReleaseID:  release.ID,
 | |
| 	}, buf, file)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "NewAttachment", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	ctx.JSON(http.StatusCreated, convert.ToReleaseAttachment(attach))
 | |
| }
 | |
| 
 | |
| // EditReleaseAttachment updates the given attachment
 | |
| func EditReleaseAttachment(ctx *context.APIContext) {
 | |
| 	// swagger:operation PATCH /repos/{owner}/{repo}/releases/{id}/assets/{attachment_id} repository repoEditReleaseAttachment
 | |
| 	// ---
 | |
| 	// summary: Edit a release attachment
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the release
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: attachment_id
 | |
| 	//   in: path
 | |
| 	//   description: id of the attachment to edit
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/EditAttachmentOptions"
 | |
| 	// responses:
 | |
| 	//   "201":
 | |
| 	//     "$ref": "#/responses/Attachment"
 | |
| 
 | |
| 	form := web.GetForm(ctx).(*api.EditAttachmentOptions)
 | |
| 
 | |
| 	// Check if release exists an load release
 | |
| 	releaseID := ctx.ParamsInt64(":id")
 | |
| 	attachID := ctx.ParamsInt64(":asset")
 | |
| 	attach, err := models.GetAttachmentByID(attachID)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetAttachmentByID", err)
 | |
| 		return
 | |
| 	}
 | |
| 	if attach.ReleaseID != releaseID {
 | |
| 		log.Info("User requested attachment is not in release, release_id %v, attachment_id: %v", releaseID, attachID)
 | |
| 		ctx.NotFound()
 | |
| 		return
 | |
| 	}
 | |
| 	// FIXME Should prove the existence of the given repo, but results in unnecessary database requests
 | |
| 	if form.Name != "" {
 | |
| 		attach.Name = form.Name
 | |
| 	}
 | |
| 
 | |
| 	if err := models.UpdateAttachment(attach); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "UpdateAttachment", attach)
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusCreated, convert.ToReleaseAttachment(attach))
 | |
| }
 | |
| 
 | |
| // DeleteReleaseAttachment delete a given attachment
 | |
| func DeleteReleaseAttachment(ctx *context.APIContext) {
 | |
| 	// swagger:operation DELETE /repos/{owner}/{repo}/releases/{id}/assets/{attachment_id} repository repoDeleteReleaseAttachment
 | |
| 	// ---
 | |
| 	// summary: Delete a release attachment
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: owner
 | |
| 	//   in: path
 | |
| 	//   description: owner of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: repo
 | |
| 	//   in: path
 | |
| 	//   description: name of the repo
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the release
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: attachment_id
 | |
| 	//   in: path
 | |
| 	//   description: id of the attachment to delete
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "204":
 | |
| 	//     "$ref": "#/responses/empty"
 | |
| 
 | |
| 	// Check if release exists an load release
 | |
| 	releaseID := ctx.ParamsInt64(":id")
 | |
| 	attachID := ctx.ParamsInt64(":asset")
 | |
| 	attach, err := models.GetAttachmentByID(attachID)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetAttachmentByID", err)
 | |
| 		return
 | |
| 	}
 | |
| 	if attach.ReleaseID != releaseID {
 | |
| 		log.Info("User requested attachment is not in release, release_id %v, attachment_id: %v", releaseID, attachID)
 | |
| 		ctx.NotFound()
 | |
| 		return
 | |
| 	}
 | |
| 	// FIXME Should prove the existence of the given repo, but results in unnecessary database requests
 | |
| 
 | |
| 	if err := models.DeleteAttachment(attach, true); err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "DeleteAttachment", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.Status(http.StatusNoContent)
 | |
| }
 |