1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-04 14:46:57 -05:00
gitea/routers/api/v1
Zettat123 0690cb076b
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)
Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)
2024-10-31 15:28:25 +00:00
..
activitypub Remove SHA1 for support for ssh rsa signing (#31857) 2024-09-07 18:05:18 -04:00
admin Move admin routers from /admin to /-/admin (#32189) 2024-10-10 04:56:49 +00:00
misc Refactor names (#31405) 2024-06-19 06:32:45 +08:00
notify Refactor names (#31405) 2024-06-19 06:32:45 +08:00
org Fix bug when a token is given public only (#32204) 2024-10-08 12:51:09 +03:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
repo Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-10-31 15:28:25 +00:00
settings Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
shared Refactor names (#31405) 2024-06-19 06:32:45 +08:00
swagger Support repo license (#24872) 2024-10-01 15:25:08 -04:00
user refactor: remove redundant err declarations (#32381) 2024-10-30 19:36:24 +00:00
utils Move admin routers from /admin to /-/admin (#32189) 2024-10-10 04:56:49 +00:00
api.go Add DISABLE_ORGANIZATIONS_PAGE and DISABLE_CODE_PAGE settings for explore pages and fix an issue related to user search (#32288) 2024-10-22 13:09:19 +08:00