1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-07-21 15:54:19 -04:00
gitea/routers/web/repo
yp05327 daf2a4c047
Fix wrong display of recently pushed notification (#25812)
There's a bug in #25715: 
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.


![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1)
The latest commit is 2 weeks ago.

![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411)

The notification comes from another repo with same branch name:

![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252)


After:
In forked repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32)
New PR Link will redirect to the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786)
In the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df)

In the same repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf)

08/15 Update:
Follow #26257, added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203


2024/04/25 Update:
Fix #30611

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-21 17:00:35 +00:00
..
actions Fix nil dereference on error (#30740) 2024-04-28 12:13:57 +08:00
setting Fix wrong transfer hint (#30889) 2024-05-08 13:17:11 +00:00
activity.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
attachment.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
blame.go Refactor file view & render (#30227) 2024-04-01 21:11:30 +08:00
branch.go Use repo object format name instead of detecting from git repository (#29702) 2024-03-10 22:30:36 +01:00
cherry_pick.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
code_frequency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
commit.go Fix code search input for different views (#30678) 2024-04-26 11:21:04 +00:00
compare.go Refactor sha1 and time-limited code (#31023) 2024-05-20 15:12:50 +00:00
contributors.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
download.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
editor_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
editor.go Fix all rounded borders, change affected tab menus to pills (#30707) 2024-04-29 20:53:15 +00:00
find.go Escape paths for find file correctly (#30026) 2024-03-23 13:07:47 +00:00
fork.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
githttp.go Make sure git version&feature are always prepared (#30877) 2024-05-06 18:34:16 +02:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
helper.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_content_history.go Migrate margin and padding helpers to tailwind (#30043) 2024-03-24 17:42:49 +01:00
issue_dependency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_label_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
issue_lock.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_pin.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_watch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue.go Fix issue label rendering in the issue popup (#30763) 2024-04-30 02:36:32 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrate.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
milestone.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
packages.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
patch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects.go Fix various problems around projects board view (#30696) 2024-05-08 13:44:57 +00:00
pull_review_test.go Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
pull_review.go Prevent allow/reject reviews on merged/closed PRs (#30686) 2024-04-27 11:55:03 +00:00
pull.go Fix misspelling of mergable (#30896) 2024-05-08 16:11:43 +00:00
recent_commits.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
render.go Refactor render (#30136) 2024-03-27 13:14:34 +00:00
repo.go Fix "force private" logic (#31012) 2024-05-20 00:56:45 +00:00
search_test.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
search.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
topic.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
treelist.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
wiki_test.go Use raw Wiki links for non-renderable Wiki files (#30273) 2024-04-10 17:49:57 +00:00
wiki.go Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-08 15:30:10 +08:00