1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-04 08:17:24 -05:00
gitea/templates
silverwind a96c73f979
Remove svg.svg class, restore .rss-icon (#24667)
Fix regression from https://github.com/go-gitea/gitea/pull/24476 where
the `svg.svg` class misaligns SVG icons across the site and streched
buttons unintentionally in vertical height.

Before (button 30.3px):
<img width="157" alt="Screenshot 2023-05-11 at 22 09 42"
src="https://github.com/go-gitea/gitea/assets/115237/0fd137ab-ab52-4cf8-afca-c45776d526d0">

After (button 30px):
<img width="160" alt="Screenshot 2023-05-11 at 22 09 59"
src="https://github.com/go-gitea/gitea/assets/115237/4b741f4b-0fd2-4fae-9bee-16a7deb098e8">

[vertical-align:
middle](https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align)
is not suitable to align icons to text because

> Aligns the middle of the element with the baseline plus half the
x-height of the parent.

Example of `vertical-align: middle` from MDN:

<img width="232" alt="Screenshot 2023-05-11 at 22 29 28"
src="https://github.com/go-gitea/gitea/assets/115237/179fb756-85a1-4cab-8219-1a4958f333e2">

So I think the
[existing](365bb77a54/web_src/css/svg.css (L3))
`vertical-align: text-top` is generally still the best bet:

<img width="241" alt="Screenshot 2023-05-11 at 22 34 24"
src="https://github.com/go-gitea/gitea/assets/115237/0cd6edf5-12c0-4bdb-8771-a900f5ba2d35">

Co-authored-by: Giteabot <teabot@gitea.io>
2023-05-12 10:23:53 +00:00
..
admin Improve queue & process & stacktrace (#24636) 2023-05-11 07:45:47 +00:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Improve template system and panic recovery (#24461) 2023-05-04 14:36:34 +08:00
code Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
explore Change join_on translation to joined_on and include placeholder for the date (#24550) 2023-05-06 18:10:30 +08:00
mail Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
org Remove svg.svg class, restore .rss-icon (#24667) 2023-05-12 10:23:53 +00:00
package Add RPM registry (#23380) 2023-05-05 20:33:37 +00:00
projects Update pin and add pin-slash (#24669) 2023-05-12 14:38:59 +08:00
repo Remove svg.svg class, restore .rss-icon (#24667) 2023-05-12 10:23:53 +00:00
shared Display owner of a runner as a tooltip instead of static text (#24377) 2023-05-12 08:43:27 +00:00
status Improve template system and panic recovery (#24461) 2023-05-04 14:36:34 +08:00
swagger Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
user Improve empty notifications display (#24668) 2023-05-12 12:06:23 +08:00
home.tmpl Improve home page template, fix Sort dropdown menu flash (#23856) 2023-04-01 13:47:54 +08:00
install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
post-install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00