mrsdizzie 52d333f084

Add better error checking for inline html diff code (#13251) ...

* Fix error in diff html rendering (#13191)

* Fix error in diff html rendering

Was missing an optional whitespace check in regex. Also noticed a rare case where diff.Type == Equal would be empty and thus get a newline attached. Fixed that too.

Fixes #13177

* Update services/gitdiff/gitdiff.go

Co-authored-by: zeripath <art27@cantab.net>

* Update gitdiff_test.go

* fmt

Co-authored-by: zeripath <art27@cantab.net>

* Add better error checking for inline html diff code (#13239)

* Add better error checking for inline html diff code

A better fix for #13191 which cleans up this code a bit and adds basic checking which should avoid writing broken HTML in future situations.

* Update gitdiff_test.go

* better regex

Co-authored-by: zeripath <art27@cantab.net>

2020-10-21 22:37:50 -04:00

..

testdata/academic-module

Fix panic when diff (#9187)

2019-11-28 17:05:57 +08:00

gitdiff_test.go

Add better error checking for inline html diff code (#13251)

2020-10-21 22:37:50 -04:00

gitdiff.go

Add better error checking for inline html diff code (#13251)

2020-10-21 22:37:50 -04:00

main_test.go

Move git diff codes from models to services/gitdiff (#7889)

2019-09-05 22:20:09 -04:00