Mihir Joshi b8270240bf Fix reverting a merge commit failing (#28794) ... Fixes #22236 --- Error occurring currently while trying to revert commit using read-tree -m approach: > 2022/12/26 16:04:43 ...rvices/pull/patch.go:240:AttemptThreeWayMerge() [E] [63a9c61a] Unable to run read-tree -m! Error: exit status 128 - fatal: this operation must be run in a work tree > - fatal: this operation must be run in a work tree We need to clone a non-bare repository for `git read-tree -m` to work. bb371aee6e adds support to create a non-bare cloned temporary upload repository. After cloning a non-bare temporary upload repository, we [set default index](https://github.com/go-gitea/gitea/blob/main/services/repository/files/cherry_pick.go#L37) (`git read-tree HEAD`). This operation ends up resetting the git index file (see investigation details below), due to which, we need to call `git update-index --refresh` afterward. Here's the diff of the index file before and after we execute SetDefaultIndex: https://www.diffchecker.com/hyOP3eJy/ Notice the **ctime**, **mtime** are set to 0 after SetDefaultIndex. You can reproduce the same behavior using these steps: ```bash $ git clone https://try.gitea.io/me-heer/test.git -s -b main $ cd test $ git read-tree HEAD $ git read-tree -m 1f085d7ed8 1f085d7ed8 9933caed00 error: Entry '1' not uptodate. Cannot merge. ``` After which, we can fix like this: ``` $ git update-index --refresh $ git read-tree -m 1f085d7ed8 1f085d7ed8 9933caed00 ```		2024-01-16 15:06:51 +00:00
..
commits_search_test.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
commitsonpr.git	Add commits dropdown in PR files view and allow commit by commit review (#25528)	2023-07-28 21:18:12 +02:00
git_hooks_test.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
glob.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
lfs.git	Test views of LFS files (#22196)	2022-12-23 07:41:56 +08:00
readme-test.git	Test renderReadmeFile (#23185)	2023-03-09 09:24:23 +08:00
repo1.git	Replace repo.namedBlob by git.TreeEntry. (#22898)	2023-03-15 16:51:39 -05:00
repo1.wiki.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
repo2.git	Allow get release download files and lfs files with oauth2 token format (#26430)	2023-10-01 10:41:52 +00:00
repo15.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
repo16.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00
repo20.git	Use beforeCommit instead of baseCommit (#22949)	2023-02-20 11:56:07 +08:00
repo-release.git	Remove git sample files and ignore them (#24271)	2023-04-22 20:29:29 +08:00
test_commit_revert.git	Fix reverting a merge commit failing (#28794)	2024-01-16 15:06:51 +00:00
utf8.git	Kd/ci playwright go test (#20123)	2022-09-02 15:18:23 -04:00