1
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-04 14:46:57 -05:00
gitea/modules/markup/markdown
Giteabot ac65aeecbd
Fixes : inline math blocks can't be preceeded/followed by alphanumerical characters () ()
Backport  by @jmlt2002

- Inline math blocks couldn't be preceeded or succeeded by
alphanumerical characters due to changes introduced in PR .
Removed the condition that caused this (precedingCharacter condition)
and added a new exit condition of the for-loop that checks if a specific
'$' was escaped using '\' so that the math expression can be rendered as
intended.
- Additionally this PR fixes another bug where math blocks of the type
'$xyz$abc$' where the dollar sign was not escaped by the user, generated
an error (shown in the screenshots below)
- Altered the tests to accomodate for the changes

Former behaviour (from try.gitea.io):

![image](https://github.com/go-gitea/gitea/assets/114936010/8f0cbb21-321d-451c-b871-c67a8e1e9235)

Fixed behaviour (from my local build):

![image](https://github.com/go-gitea/gitea/assets/114936010/5c22687c-6f11-4407-b5e7-c14b838bc20d)

(Edit) Source code for the README.md file:
```
$x$ -$x$ $x$-

a$xa$ $xa$a 1$xb$ $xb$1

$a a$b b$

a$b $a a$b b$

$a a\$b b$
```

Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
Co-authored-by: João Tiago <114936010+jmlt2002@users.noreply.github.com>
2024-04-03 06:17:02 +00:00
..
math Fixes : inline math blocks can't be preceeded/followed by alphanumerical characters () () 2024-04-03 06:17:02 +00:00
ast.go Refactor markdown attention render () 2024-03-16 11:34:38 +00:00
convertyaml.go Improve Wiki TOC () 2023-04-17 15:05:19 -04:00
goldmark.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
markdown_test.go Fixes : inline math blocks can't be preceeded/followed by alphanumerical characters () () 2024-04-03 06:17:02 +00:00
markdown.go Refactor markdown attention render () 2024-03-22 12:16:23 +00:00
meta_test.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
meta.go Replace interface{} with any () 2023-07-04 18:36:08 +00:00
prefixed_id.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
renderconfig_test.go Improve Wiki TOC () 2023-04-17 15:05:19 -04:00
renderconfig.go Fix task list checkbox toggle to work with YAML front matter () 2023-06-13 14:44:47 +08:00
toc.go Refactor locale&string&template related code () 2024-02-14 21:48:45 +00:00
transform_blockquote.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
transform_codespan.go Fix markdown color code detection () () 2024-03-31 12:25:15 +00:00
transform_heading.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
transform_image.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
transform_link.go Refactor markdown render () 2024-03-28 02:26:13 +00:00
transform_list.go Refactor markdown render () 2024-03-28 02:26:13 +00:00