Giteabot
58a0ba711d
Fix and rewrite markup anchor processing ( #29931 ) ( #29946 )
...
Backport #29931 by @lunny
Fix #29877
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-03-21 01:09:08 +02:00
wxiaoguang
b4a6c6fd7a
Fix loadOneBranch panic ( #29938 ) ( #29939 )
...
Backport #29938
Try to fix #29936
Far from ideal, but still better than panic.
2024-03-20 22:31:32 +08:00
Lunny Xiao
3fd15aeff2
Add cache for dashbaord commit status ( #29932 )
...
backport #29444
2024-03-20 10:34:40 +00:00
Giteabot
0873088223
Show Actions post step when it's running ( #29926 ) ( #29928 )
...
Backport #29926 by @wolfogre
The post step was always waiting, even if all steps were done. Then,
once the task was done, the post step became success immediately.
Before:
<img width="915" alt="xnip_240320_120228"
src="https://github.com/go-gitea/gitea/assets/9418365/00347430-f998-4c43-917a-bf6dd6d0e333 ">
After:
<img width="905" alt="xnip_240320_120443"
src="https://github.com/go-gitea/gitea/assets/9418365/a419b111-17c2-4029-a022-c761cc419091 ">
Co-authored-by: Jason Song <i@wolfogre.com>
2024-03-20 06:25:11 +00:00
Lunny Xiao
ff27ca32ca
Notify reviewers added via CODEOWNERS ( #29842 ) ( #29902 )
...
backport #29842
Co-authored-by: Jimmy Praet <jimmy.praet@telenet.be>
2024-03-20 06:02:24 +00:00
Giteabot
eb302deb18
Fix the wrong default value of ENABLE_OPENID_SIGNIN on docs ( #29925 ) ( #29927 )
...
Backport #29925 by @lunny
Fix #29923
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-03-20 05:08:24 +00:00
yp05327
aae96cc62b
Fix invalid link of the commit status when ref is tag ( #29752 ) ( #29908 )
...
Backport #29752
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-03-20 04:36:32 +00:00
Lunny Xiao
5f7b6b55a5
Only do counting when count_only=true for repo dashboard ( #29884 ) ( #29905 )
...
Ref: #29878
Backport #29884
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-20 11:02:35 +08:00
Giteabot
408c92938b
Fix PR creation via api between branches of same repo with head field namespaced ( #26986 ) ( #29857 )
...
Backport #26986 by @norohind
Fix #20175
Current implementation of API does not allow creating pull requests
between branches of the same
repo when you specify *namespace* (owner of the repo) in `head` field in
http request body.
---------
Co-authored-by: norohind <60548839+norohind@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-03-20 09:38:30 +08:00
wxiaoguang
b9dd5dd471
Fix template error when comment review doesn't exist ( #29888 ) ( #29889 )
...
Backport #29888
2024-03-19 15:00:01 +08:00
Lunny Xiao
440be51a45
Fix bug on template ( #29887 )
...
Caused by #29807
Fix #29886
2024-03-18 15:24:07 +00:00
Giteabot
00ea9af8e1
Editor error message misleading due to re-used key. ( #29859 ) ( #29876 )
...
Backport #29859 by @buckybytes
The error message:
`editor.file_changed_while_editing = The file contents have changed
since you started editing. <a target="_blank" rel="noopener noreferrer"
href="%s">Click here</a> to see them or <strong>Commit Changes
again</strong> to overwrite them.`
Is re-used in inappropriate contexts. The link in the key goes to a 404
when the key is used in a situation where the file contents have not
changed.
Added two new keys to differentiate commit id mismatch and push out of
date conditions.
Co-authored-by: buckybytes <158571971+buckybytes@users.noreply.github.com>
2024-03-18 14:45:43 +08:00
Giteabot
c044510ca8
Fix user id column case ( #29863 ) ( #29867 )
...
Backport #29863 by @lng2020
Sometimes the column name is case-sensitive and it may cause 500.
Co-authored-by: Nanguan Lin <nanguanlin6@gmail.com>
2024-03-17 13:51:15 +00:00
Lunny Xiao
85f31eb643
Fix codeowner detected diff base branch to mergebase ( #29783 ) ( #29807 )
...
Fix #29763
Backport #29783
This PR fixes 2 problems with CodeOwner in the pull request.
- Don't use the pull request base branch but merge-base as a diff base
to detect the code owner.
- CodeOwner detection in fork repositories will be disabled because
almost all the fork repositories will not change CODEOWNERS files but it
should not be used on fork repositories' pull requests.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-17 02:40:06 +01:00
Giteabot
8242c3c88c
fix double border and border-radius on empty action steps ( #29845 ) ( #29850 )
...
Backport #29845 by @silverwind
Before, double border-bottom and incorrect border-radius:
<img width="914" alt="Screenshot 2024-03-16 at 14 46 31"
src="https://github.com/go-gitea/gitea/assets/115237/6ea63c42-754c-420c-a0f5-c889a8507d9f ">
After, both fixed:
<img width="917" alt="Screenshot 2024-03-16 at 14 45 59"
src="https://github.com/go-gitea/gitea/assets/115237/9d3f2dba-6b22-441d-8e99-5809d5f1f1c0 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-03-16 18:16:45 +01:00
6543
0cbbcf20e3
Make meilisearch do exact search for issues ( #29740 & #29671 ) ( #29846 )
...
Backport https://github.com/go-gitea/gitea/pull/29740 (based on #29671
...)
2024-03-16 17:01:40 +01:00
Giteabot
47dc4598a3
Fix for attribute not pointing to the ID of the color picker ( #29813 ) ( #29815 )
...
Backport #29813 by @yardenshoham
It didn't include the word picker.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-03-15 13:33:46 +00:00
silverwind
817d5e4d30
Use Temporal.PlainDate for absolute dates ( #29804 ) ( #29808 )
...
Backport https://github.com/go-gitea/gitea/pull/29804 .
Use the upcoming
[Temporal.PlainDate](https://tc39.es/proposal-temporal/docs/plaindate.html )
via polyfill. If there is any remaining bugs in `<absolute-date>` this
will iron them out. I opted for the lightweight polyfill because both
seem to achieve our goal of localizeable absolute dates.
- With
[`@js-temporal/polyfill`](https://www.npmjs.com/package/@js-temporal/polyfill )
chunk size goes from 81.4 KiB to 274 KiB
- With
[`temporal-polyfill`](https://www.npmjs.com/package/temporal-polyfill )
chunk size goes from 81.4 KiB to 142 KiB
Also see [this
table](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#comparison-with-js-temporalpolyfill )
for more comparisons of these polyfills. Soon there will be
[treeshakable
API](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#tree-shakable-api )
as well which will further reduce size.
2024-03-15 11:20:42 +01:00
Lunny Xiao
31ab839a65
Update Chroma to v2.13.0 ( #29732 ) ( #29805 )
...
Backport #29732
This adds new lexers and includes some fixes. See
https://github.com/alecthomas/chroma/releases/tag/v2.13.0 for the full
changelog.
Co-authored-by: JakobDev <jakobdev@gmx.de>
2024-03-15 16:45:10 +08:00
Giteabot
df23ec0f8b
Fix Safari spinner rendering ( #29801 ) ( #29802 )
...
Backport #29801 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/29041
Fixes: https://github.com/go-gitea/gitea/pull/29713
Any of the `width: *-content` properties seem to workaround this Webkit
bug, this one seemed most suitable.
Before:
<img width="184" alt="Screenshot 2024-03-14 at 22 29 58"
src="https://github.com/go-gitea/gitea/assets/115237/6effc5f0-bc64-4752-be74-9c43b3974407 ">
After:
<img width="177" alt="Screenshot 2024-03-14 at 22 30 30"
src="https://github.com/go-gitea/gitea/assets/115237/5de244d7-6b46-428e-957c-4b10f53e2441 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-03-14 22:08:59 +00:00
Giteabot
e0a9a921af
Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env ( #29788 ) ( #29791 )
...
Backport #29788 by @wolfogre
I was trying to run unit tests for Gitea on act runner, by using `make
test`.
It failed with log:
```
2024/03/14 03:09:26 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run as root. Sorry. If you need to use privileged TCP ports please instead use setcap and the `cap_net_bind_service` permission
```
So it will be convenient to skip by setting environment, since it's OK
to use root user in job containers.
It's not a bug, but I want to backport it to v1.21 since it doesn't
break anything.
---------
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-14 10:02:37 +00:00
Giteabot
e03cf66e8b
Fix missing translation on milestons ( #29785 ) ( #29789 )
...
Backport #29785 by @lunny
Caused by #26569
Fix #29778
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-03-14 09:21:04 +01:00
Lunny Xiao
61db562a5f
Fix user router possbile panic ( #29751 ) ( #29786 )
...
regression from #28023
backport #29751
2024-03-14 12:44:14 +08:00
sillyguodong
538efb9df7
Make runs-on support variable expression ( #29468 ) ( #29782 )
...
backport #29468
Close issue: https://gitea.com/gitea/act_runner/issues/445
Follow: https://gitea.com/gitea/act/pulls/91
Move `getSecretsOfTask` and `getVariablesOfTask` under models because of
circular dependency issues.
2024-03-14 10:19:01 +08:00
Giteabot
5e3581f073
Fix possible NPE in ToPullReviewList ( #29759 ) ( #29775 )
...
Backport #29759 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-13 21:42:17 +01:00
Denys Konovalov
bb9860307f
Update to labeler v5 ( #29721 ) ( #29765 )
...
Backport #29721
Updated to actions/labeler@v5
Updated labeler config accordingly, also improved the config and added
more labels.
Co-authored-by: Giteabot <teabot@gitea.io>
2024-03-13 13:42:55 +00:00
wxiaoguang
bb2640c485
Fix incorrect package link method calls in templates ( #29580 ) ( #29764 )
...
Backport #29580
Fix #29562
Fix #29762
Follow #29531
2024-03-13 19:43:31 +08:00
Giteabot
462ae88fc2
Suppress error from monaco-editor ( #29684 ) ( #29758 )
...
Backport #29684 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/29414
I see no way for us to catch this error, so downgrade it until
https://github.com/microsoft/monaco-editor/issues/4325 is fixed, which
will likely take a few weeks to propagate up from vscode.
The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates ) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.
Co-authored-by: silverwind <me@silverwind.io>
2024-03-13 09:02:00 +01:00
Lunny Xiao
1e4d5a5594
Add changelog for 1.21.8 ( #29735 )
...
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
2024-03-13 03:10:02 +00:00
Giteabot
6124c78de0
Fix date rendering by adding <gitea-absolute-date> ( #29725 ) ( #29747 )
...
Backport #29725 by @silverwind
Alternative to: https://github.com/go-gitea/gitea/pull/29698
Fixes: https://github.com/go-gitea/gitea/issues/29034
<img width="278" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/12ecd967-2723-410d-8a28-a1b0f41b7bba ">
It also fixes a secondary issue that we were showing timestamp tooltips
over date, which makes no sense, so these are now gone as well:
<img width="284" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/a70432f3-97b6-41e6-b202-b53b76924a66 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-03-13 01:04:58 +01:00
Giteabot
12b429c0d1
Improve CSV rendering ( #29638 ) ( #29744 )
...
Backport #29638 by @silverwind
Before:
<img width="1332" alt="Screenshot 2024-03-06 at 21 42 17"
src="https://github.com/go-gitea/gitea/assets/115237/0ea07eee-31f8-4783-bd56-37bd8396f00d ">
After:
<img width="1336" alt="Screenshot 2024-03-06 at 21 41 58"
src="https://github.com/go-gitea/gitea/assets/115237/eb7f9cc9-587f-4e3b-92bd-cc67ca639963 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-03-12 21:45:45 +00:00
Lunny Xiao
8c31456a87
Use Get but not Post to get actions artifacts ( #29734 ) ( #29737 )
...
backport #29734
2024-03-12 17:31:45 +01:00
Giteabot
4bfc43ef8d
Fix inconsistent rendering of block mathematical expressions ( #29677 ) ( #29711 )
...
Backport #29677 by @yp05327
Fix #28735
GitHub render `\```math\``` ` as a block now.
Add `display` class will render it as a block.
After:
Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-11 10:10:07 +01:00
Giteabot
93e105a228
fix: rendering internal file links in org ( #29669 ) ( #29705 )
...
Backport #29669 by @ankitrgadiya
The internal links to other files in the repository were not rendering
with the Src Prefix (/src/branch-name/file-path). This commit fixes that
by using the `SrcLink` as base if available.
Resolves #29668
Co-authored-by: Ankit R Gadiya <git@argp.in>
2024-03-10 18:29:17 +01:00
Lunny Xiao
e8b6d28ab9
Fix bug hidden on CI and make ci failed if tests failure ( #29254 ) ( #29662 )
...
Backport #29254
The tests on migration tests failed but CI reports successfully
https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141
This PR will fix the bug on migrations and also the CI hidden behaviour.
The reason is on the Makefile
`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.
But
`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
done`
will not work.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2024-03-09 09:44:02 +00:00
silverwind
346b662305
Don't show AbortErrors on logout ( #29639 ) ( #29667 )
...
Backport https://github.com/go-gitea/gitea/pull/29639 .
When logging out of Gitea, a error toast can be seen for a split second.
I don't know why or how it happens but I found it it's an `AbortError`
(related to
[AbortController#abort](https://developer.mozilla.org/en-US/docs/Web/API/AbortController/abort )),
so let's hide it.
2024-03-09 17:22:18 +08:00
Giteabot
25b0c99a41
Use more specific selector for name links ( #29679 ) ( #29681 )
...
Backport #29679 by @silverwind
Followup https://github.com/go-gitea/gitea/pull/29305 . As per discussion
in https://github.com/go-gitea/gitea/pull/29666#discussion_r1517506422 ,
make this selector only search in the current `.markup` document, as
there can be multiples displayed at the same time.
@DanielMatiasCarvalho maybe you can review.
Co-authored-by: silverwind <me@silverwind.io>
2024-03-09 08:40:05 +08:00
Giteabot
bfc7c8a598
Fix user-defined markup links targets ( #29305 ) ( #29666 )
...
Backport #29305 by @DanielMatiasCarvalho
This seeks to fix the bug reported on issue #29196 .
Cause:
ID's with custom characters (- , _ , etc.), were not linking correctly
in the Markdown file when rendered in the browser because the ID in the
respective destinies would be different than the one in anchor, while
for IDs with only letters, the ID would be the same.
Fix:
It was suggested that to fix this bug, it should more or less like
GitHub does it. While in gitea the anchors would be put in HTML like
this:
```
<p dir="auto"><a href="#user-content-_toc152597800" rel="nofollow">Review</a></p>
<p dir="auto"><a href="#user-content-_toc152597802" rel="nofollow">Staging</a></p>
<p dir="auto"><a href="#user-content-_toc152597803" rel="nofollow">Development</a></p>
<p dir="auto"><a href="#user-content-_toc152597828" rel="nofollow">Testing</a></p>
<p dir="auto"><a href="#user-content-_toc152597829" rel="nofollow">Unit-tests</a></p>
```
In GitHub, the same anchor's href properties would be the same without
"user-content-" trailing behind.
So my code made sure to change those anchors, so it would not include
"user-content-" and then add respective Event Listeners so it would
scroll into the supposed places.
Fixes : #29196
Co-authored-by: DC <106393991+DanielMatiasCarvalho@users.noreply.github.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-03-08 16:53:36 +00:00
Giteabot
1f89763744
Fix commit_status problem when testing ( #29672 ) ( #29675 )
...
Backport #29672 by @charles7668
Close #29661
fix #29656
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
2024-03-08 16:04:23 +00:00
Lunny Xiao
a129c0c06c
Fix 500 when deleting account with incorrect password or unsupported login type ( #29579 ) ( #29656 )
...
Fix #26210
Backport #29579
Co-authored-by: Jason Song <i@wolfogre.com>
2024-03-08 15:43:57 +01:00
yp05327
bd7de0c4e4
Add empty repo check in DetectAndHandleSchedules ( #29606 ) ( #29659 )
...
Backport #29606
2024-03-08 09:50:04 +00:00
Giteabot
6651d2d87a
Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize ( #29653 ) ( #29663 )
...
Backport #29653 by @yp05327
Fix #29506
Co-authored-by: yp05327 <576951401@qq.com>
2024-03-08 09:13:58 +00:00
Giteabot
76b6754c3a
Fixing the issue when status check per rule matches multiple actions ( #29631 ) ( #29655 )
...
Backport #29631 by @charles7668
Close #29628
rule
```
Test / Build*
Test / Build *
Test / Build 2*
Test / Build 1*
```
rule2
```
Test / Build*
Test / Build 1*
```
rule3
```
Test / Build*
Test / Build 1*
NotExist*
```
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
Co-authored-by: Zettat123 <zettat123@gmail.com>
2024-03-08 13:24:32 +08:00
Giteabot
0b5a4e7db4
Use strict protocol check when redirect ( #29642 ) ( #29644 )
...
Backport #29642 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-07 03:53:33 +00:00
silverwind
b6a2b9594a
Update Twitter Logo ( #29621 ) ( #29633 )
...
Backport https://github.com/go-gitea/gitea/pull/29621
<img width="430" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/9cf7b0a3-406b-4dd6-ab3d-d31a96b9335a ">
2024-03-06 17:41:23 +01:00
Giteabot
6ee58a0ac2
Avoid issue info panic ( #29625 ) ( #29632 )
...
Backport #29625 by wxiaoguang
Fix #29624
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-06 13:33:29 +00:00
wxiaoguang
2f1eb619bc
Avoid unexpected panic in graceful manager ( #29629 ) ( #29630 )
...
Backport #29629
2024-03-06 11:00:21 +00:00
Giteabot
9db426ad8c
Fix wrong line number in code search result ( #29260 ) ( #29623 )
...
Backport #29260 by @yp05327
Fix #29136
Before:
The result is a table and all line numbers are all in one row.
After:
~~Updated:~~
~~added `active` class to the target line.~~
Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-03-06 10:05:41 +01:00
techknowlogick
a8277cfc8f
bump protobuf module ( #29617 ) ( #29619 )
...
backport #29617
2024-03-06 13:16:35 +08:00
Lunny Xiao
5667ef9aab
Add missing database transaction for new issue ( #29490 ) ( #29607 )
...
When creating an issue, inserting issue, assign users and set project
should be in the same transaction.
Backport #29490
2024-03-05 16:37:55 +00:00
