mirror of
https://github.com/go-gitea/gitea.git
synced 2024-09-06 23:44:20 -04:00
Always return a list from GetCommitsFromIDs (#12981)
`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where it expects that `c.Commits` is not nil. This potentially nil set causes a NPE in in #12953 Fix #12953 Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
parent
1bcf1ad643
commit
fe79b13ab2
@ -504,10 +504,6 @@ func (repo *Repository) getBranches(commit *Commit, limit int) ([]string, error)
|
||||
|
||||
// GetCommitsFromIDs get commits from commit IDs
|
||||
func (repo *Repository) GetCommitsFromIDs(commitIDs []string) (commits *list.List) {
|
||||
if len(commitIDs) == 0 {
|
||||
return nil
|
||||
}
|
||||
|
||||
commits = list.New()
|
||||
|
||||
for _, commitID := range commitIDs {
|
||||
|
Loading…
Reference in New Issue
Block a user