aniani/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-11-10 02:38:07 -05:00
Code Activity

Fix cli "Before" handling (#35797)

Browse Source 
Regression of #34973

Fix #35796
This commit is contained in:
wxiaoguang
2025-11-01 02:12:03 +08:00
committed by GitHub
parent ef90befef1
commit de70cd3853
5 changed files with 55 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/integration/cmd_keys_test.go
View File

@@ -10,6 +10,7 @@ import (
"code.gitea.io/gitea/cmd"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/test"
"code.gitea.io/gitea/modules/util"
"github.com/stretchr/testify/assert"
@@ -36,13 +37,15 @@ func Test_CmdKeys(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// FIXME: this test is not quite right. Each "command run" always re-initializes settings
defer test.MockVariableValue(&cmd.CmdKeys.Before, nil)() // don't re-initialize logger during the test
var stdout, stderr bytes.Buffer
app := &cli.Command{
Writer: &stdout,
ErrWriter: &stderr,
Commands: []*cli.Command{cmd.CmdKeys},
}
cmd.CmdKeys.HideHelp = true
err := app.Run(t.Context(), append([]string{"prog"}, tt.args...))
if tt.wantErr {
assert.Error(t, err)