From a8fa380c2521c2d3d3e76b4b4160a55d903b63d9 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Thu, 17 Dec 2020 15:37:56 +0100
Subject: [PATCH] Dropdown triangle fixes (#14028)

* Dropdown triangle fixes

Fomantic's CSS assumes the dropdown triangles are fonts but we've recently
swapped them for SVG so we need to wrestle a bit with Fomantic to get it
to display properly and not cause buttons to resize.

Fixes: https://github.com/go-gitea/gitea/issues/14014

* move css and add link
---
 web_src/less/_base.less   | 20 ++++++++++++++++++++
 web_src/less/_review.less |  6 ------
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/web_src/less/_base.less b/web_src/less/_base.less
index 9f46e3ee7b..45cd549320 100644
--- a/web_src/less/_base.less
+++ b/web_src/less/_base.less
@@ -1734,6 +1734,26 @@ table th[data-sortt-desc] {
   }
 }
 
+/* fix up SVG dropdown triangles because fomantic thinks they are icon fonts */
+/* see https://github.com/go-gitea/gitea/issues/14014 */
+.ui.dropdown > .dropdown.icon,
+.btn-review > .dropdown.icon {
+  height: auto !important;
+  margin-left: .5rem !important;
+  margin-top: -1px !important;
+  margin-bottom: -1px !important;
+  margin-right: -.5rem !important;
+}
+.ui.button.dropdown > .dropdown.icon,
+.btn-review > .dropdown.icon {
+  float: right !important;
+}
+.ui.selection.dropdown > .search.icon,
+.ui.selection.dropdown > .delete.icon,
+.ui.selection.dropdown > .dropdown.icon {
+  top: 0 !important;
+}
+
 /* limit width of all direct dropdown menu children */
 /* https://github.com/go-gitea/gitea/pull/10835 */
 .dropdown:not(.selection) > .menu:not(.review-box) > *:not(.header) {
diff --git a/web_src/less/_review.less b/web_src/less/_review.less
index 029c96fc50..2d0ac1b324 100644
--- a/web_src/less/_review.less
+++ b/web_src/less/_review.less
@@ -142,12 +142,6 @@ a.blob-excerpt:hover {
   color: #fff;
 }
 
-.btn-review > .dropdown.icon {
-  float: right;
-  height: 12px !important;
-  margin-left: .5rem;
-}
-
 @media @mediaSm {
   #review-box > .menu {
     > .ui.segment {