mirror of
https://github.com/go-gitea/gitea.git
synced 2024-10-30 08:27:32 -04:00
Publish Review
buttons should indicate why they are disabled (#23598)
Adding tooltip on "Approve" and "Review Changes" buttons. is try to do by them self on their PR. Resolves https://github.com/go-gitea/gitea/issues/23547 `Approve` tootip text :- "Pull request authors can’t approve their own pull request" `Request Changes` tooltip text:- "Pull request authors can’t request changes on their own pull request" Before https://user-images.githubusercontent.com/115237/225984020-306c048f-cb9b-4dee-8929-1c74c331518b.png After <img width="841" alt="image" src="https://user-images.githubusercontent.com/80308335/226445845-b5f6f6c9-f0dc-4934-a282-3b8be06417a8.png">
This commit is contained in:
parent
8f3aaef374
commit
a8c30a45fa
@ -2265,7 +2265,9 @@ diff.review.header = Submit review
|
|||||||
diff.review.placeholder = Review comment
|
diff.review.placeholder = Review comment
|
||||||
diff.review.comment = Comment
|
diff.review.comment = Comment
|
||||||
diff.review.approve = Approve
|
diff.review.approve = Approve
|
||||||
|
diff.review.self_reject = Pull request authors can't request changes on their own pull request
|
||||||
diff.review.reject = Request changes
|
diff.review.reject = Request changes
|
||||||
|
diff.review.self_approve = Pull request authors can't approve their own pull request
|
||||||
diff.committed_by = committed by
|
diff.committed_by = committed by
|
||||||
diff.protected = Protected
|
diff.protected = Protected
|
||||||
diff.image.side_by_side = Side by Side
|
diff.image.side_by_side = Side by Side
|
||||||
|
@ -22,9 +22,22 @@
|
|||||||
</div>
|
</div>
|
||||||
{{end}}
|
{{end}}
|
||||||
<div class="ui divider"></div>
|
<div class="ui divider"></div>
|
||||||
<button type="submit" name="type" value="approve" {{if and $.IsSigned ($.Issue.IsPoster $.SignedUser.ID)}} disabled {{end}} class="ui submit green tiny button btn-submit">{{$.locale.Tr "repo.diff.review.approve"}}</button>
|
{{$showSelfTooltip := (and $.IsSigned ($.Issue.IsPoster $.SignedUser.ID))}}
|
||||||
|
{{if $showSelfTooltip}}
|
||||||
|
<span class="gt-dib tooltip" data-content="{{$.locale.Tr "repo.diff.review.self_approve"}}">
|
||||||
|
<button type="submit" name="type" value="approve" disabled class="ui submit green tiny button btn-submit">{{$.locale.Tr "repo.diff.review.approve"}}</button>
|
||||||
|
</span>
|
||||||
|
{{else}}
|
||||||
|
<button type="submit" name="type" value="approve" class="ui submit green tiny button btn-submit">{{$.locale.Tr "repo.diff.review.approve"}}</button>
|
||||||
|
{{end}}
|
||||||
<button type="submit" name="type" value="comment" class="ui submit tiny basic button btn-submit">{{$.locale.Tr "repo.diff.review.comment"}}</button>
|
<button type="submit" name="type" value="comment" class="ui submit tiny basic button btn-submit">{{$.locale.Tr "repo.diff.review.comment"}}</button>
|
||||||
<button type="submit" name="type" value="reject" {{if and $.IsSigned ($.Issue.IsPoster $.SignedUser.ID)}} disabled {{end}} class="ui submit red tiny button btn-submit">{{$.locale.Tr "repo.diff.review.reject"}}</button>
|
{{if $showSelfTooltip}}
|
||||||
|
<span class="gt-dib tooltip" data-content="{{$.locale.Tr "repo.diff.review.self_reject"}}">
|
||||||
|
<button type="submit" name="type" value="reject" disabled class="ui submit red tiny button btn-submit">{{$.locale.Tr "repo.diff.review.reject"}}</button>
|
||||||
|
</span>
|
||||||
|
{{else}}
|
||||||
|
<button type="submit" name="type" value="reject" class="ui submit red tiny button btn-submit">{{$.locale.Tr "repo.diff.review.reject"}}</button>
|
||||||
|
{{end}}
|
||||||
</form>
|
</form>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
Loading…
Reference in New Issue
Block a user