From 8bd1218e8b3e2d33d6200e6b6b1f77c6c8177036 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 25 Feb 2024 13:19:39 +0800 Subject: [PATCH] Fix possible xss bug --- templates/repo/issue/view_content/comments.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/repo/issue/view_content/comments.tmpl b/templates/repo/issue/view_content/comments.tmpl index 346ceee6c6..e1a67cc8b6 100644 --- a/templates/repo/issue/view_content/comments.tmpl +++ b/templates/repo/issue/view_content/comments.tmpl @@ -607,12 +607,12 @@ {{template "shared/user/avatarlink" dict "user" .Poster}} {{template "shared/user/authorlink" .Poster}} - {{$newProjectDisplayHtml := .CommentMetaData.ProjectTitle|Safe}} + {{$newProjectDisplayHtml := .CommentMetaData.ProjectTitle}} {{if .Project}} {{$trKey := printf "projects.type-%d.display_name" .Project.Type}} {{$newProjectDisplayHtml = printf `%s %s` (svg .Project.IconName) (.Project.Link ctx) (ctx.Locale.Tr $trKey | Escape) (.Project.Title | Escape)}} {{end}} - {{ctx.Locale.Tr "repo.issues.move_to_column_of_project" (.CommentMetaData.ProjectColumnTitle|Safe) ($newProjectDisplayHtml|Safe) $createdStr}} + {{ctx.Locale.Tr "repo.issues.move_to_column_of_project" (.CommentMetaData.ProjectColumnTitle|Escape) ($newProjectDisplayHtml|Safe) $createdStr}} {{end}}