diff --git a/models/issue_comment.go b/models/issue_comment.go index a9c27060cc..8d3d0c3064 100644 --- a/models/issue_comment.go +++ b/models/issue_comment.go @@ -818,7 +818,7 @@ func fetchCodeComments(e Engine, issue *Issue, currentUser *User) (map[string]ma // If the review is pending only the author can see the comments if re.Type == ReviewTypePending && (currentUser == nil || currentUser.ID != re.ReviewerID) { - continue + continue } comment.Review = re } diff --git a/models/review_test.go b/models/review_test.go index c8dd0fb333..8a968b324c 100644 --- a/models/review_test.go +++ b/models/review_test.go @@ -53,8 +53,8 @@ func TestReviewType_Icon(t *testing.T) { func TestFindReviews(t *testing.T) { assert.NoError(t, PrepareTestDatabase()) reviews, err := FindReviews(FindReviewOptions{ - Type: ReviewTypeApprove, - IssueID: 2, + Type: ReviewTypeApprove, + IssueID: 2, ReviewerID: 1, }) assert.NoError(t, err) @@ -71,7 +71,7 @@ func TestGetCurrentReview(t *testing.T) { assert.NoError(t, err) assert.NotNil(t, review) assert.Equal(t, ReviewTypePending, review.Type) - assert.Equal(t, "Pending Review", review.Content ) + assert.Equal(t, "Pending Review", review.Content) user2 := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User) review2, err := GetCurrentReview(user2, issue) @@ -87,9 +87,9 @@ func TestCreateReview(t *testing.T) { user := AssertExistsAndLoadBean(t, &User{ID: 1}).(*User) review, err := CreateReview(CreateReviewOptions{ - Content: "New Review", - Type: ReviewTypePending, - Issue: issue, + Content: "New Review", + Type: ReviewTypePending, + Issue: issue, Reviewer: user, }) assert.NoError(t, err)