From 58b36cc42291e274dbc80d2d617e63119c64542c Mon Sep 17 00:00:00 2001
From: delvh <dev.lh@web.de>
Date: Wed, 12 Apr 2023 13:59:17 +0200
Subject: [PATCH] Add tooltips to `Hide comment type` settings where necessary
 (#21306)

Previously, this setting was pretty confusing for users, especially the
difference between "reference" and "issue reference".
Related: #21321.
---
 options/locale/locale_en-US.ini         | 3 +++
 templates/user/settings/appearance.tmpl | 7 +++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index cf3208b5bd..b5e1c718ee 100644
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -611,6 +611,9 @@ cancel = Cancel
 language = Language
 ui = Theme
 hidden_comment_types = Hidden comment types
+hidden_comment_types_description = Comment types checked here will not be shown inside issue pages. Checking "Label" for example removes all "<user> added/removed <label>" comments.
+hidden_comment_types.ref_tooltip = Comments where this issue was referenced from another issue/commit/…
+hidden_comment_types.issue_ref_tooltip = Comments where the user changes the branch/tag associated with the issue
 comment_type_group_reference = Reference
 comment_type_group_label = Label
 comment_type_group_milestone = Milestone
diff --git a/templates/user/settings/appearance.tmpl b/templates/user/settings/appearance.tmpl
index 528fe52f2b..c78caedc96 100644
--- a/templates/user/settings/appearance.tmpl
+++ b/templates/user/settings/appearance.tmpl
@@ -74,10 +74,13 @@
 			{{.locale.Tr "settings.hidden_comment_types"}}
 		</h4>
 		<div class="ui attached segment">
+			<p class="help">
+				{{.locale.Tr "settings.hidden_comment_types_description"}}
+			</p>
 			<form class="ui form" action="{{.Link}}/hidden_comments" method="post">
 				{{.CsrfTokenHtml}}
 				<div class="inline field">
-					<div class="ui checkbox">
+					<div class="ui checkbox" data-tooltip-content="{{.locale.Tr "settings.hidden_comment_types.ref_tooltip"}}">
 						<input name="reference" type="checkbox" {{if(call .IsCommentTypeGroupChecked "reference")}}checked{{end}}>
 						<label>{{.locale.Tr "settings.comment_type_group_reference"}}</label>
 					</div>
@@ -156,7 +159,7 @@
 					</div>
 				</div>
 				<div class="inline field">
-					<div class="ui checkbox">
+					<div class="ui checkbox" data-tooltip-content="{{.locale.Tr "settings.hidden_comment_types.issue_ref_tooltip"}}">
 						<input name="issue_ref" type="checkbox" {{if (call .IsCommentTypeGroupChecked "issue_ref")}}checked{{end}}>
 						<label>{{.locale.Tr "settings.comment_type_group_issue_ref"}}</label>
 					</div>