mirror of
https://github.com/go-gitea/gitea.git
synced 2024-09-06 23:44:20 -04:00
Always show usernames in reaction tooltips (#26444)
Even if GetDisplayName() is normally preferred elsewhere, this change provides more consistency, as usernames are also always being shown when participating in a conversation taking place in an issue or a pull request. This change makes conversations easier to follow, as you would not have to have a mental association between someone's username and someone's real name in order to follow what is happening. This behavior matches GitHub's. Optimally, both the username and the full name (if applicable) could be shown, but such an effort is a much bigger task that needs to be thought out well.
This commit is contained in:
parent
7a69d71733
commit
2cbd377e1f
@ -377,7 +377,7 @@ func (list ReactionList) GetFirstUsers() string {
|
|||||||
if buffer.Len() > 0 {
|
if buffer.Len() > 0 {
|
||||||
buffer.WriteString(", ")
|
buffer.WriteString(", ")
|
||||||
}
|
}
|
||||||
buffer.WriteString(reaction.User.DisplayName())
|
buffer.WriteString(reaction.User.Name)
|
||||||
if rem--; rem == 0 {
|
if rem--; rem == 0 {
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
@ -109,7 +109,7 @@ func TestIssueReactionCount(t *testing.T) {
|
|||||||
reactions := reactionsList.GroupByType()
|
reactions := reactionsList.GroupByType()
|
||||||
assert.Len(t, reactions["heart"], 4)
|
assert.Len(t, reactions["heart"], 4)
|
||||||
assert.Equal(t, 2, reactions["heart"].GetMoreUserCount())
|
assert.Equal(t, 2, reactions["heart"].GetMoreUserCount())
|
||||||
assert.Equal(t, user1.DisplayName()+", "+user2.DisplayName(), reactions["heart"].GetFirstUsers())
|
assert.Equal(t, user1.Name+", "+user2.Name, reactions["heart"].GetFirstUsers())
|
||||||
assert.True(t, reactions["heart"].HasUser(1))
|
assert.True(t, reactions["heart"].HasUser(1))
|
||||||
assert.False(t, reactions["heart"].HasUser(5))
|
assert.False(t, reactions["heart"].HasUser(5))
|
||||||
assert.False(t, reactions["heart"].HasUser(0))
|
assert.False(t, reactions["heart"].HasUser(0))
|
||||||
|
Loading…
Reference in New Issue
Block a user