aniani/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-02-02 15:09:33 -05:00
Code

test(metrics): add middleware test

Browse Source
This commit is contained in:
TheFox0x7 2025-01-23 23:59:44 +01:00
parent 0b1e3254dd
commit 056a308b2a
3 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
go.mod
View File

@ -242,6 +242,7 @@ require (
github.com/klauspost/pgzip v1.2.6 // indirect github.com/klauspost/pgzip v1.2.6 // indirect
github.com/kr/pretty v0.3.1 // indirect github.com/kr/pretty v0.3.1 // indirect
github.com/kr/text v0.2.0 // indirect github.com/kr/text v0.2.0 // indirect
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/libdns/libdns v0.2.2 // indirect github.com/libdns/libdns v0.2.2 // indirect
github.com/magiconair/properties v1.8.7 // indirect github.com/magiconair/properties v1.8.7 // indirect
github.com/mailru/easyjson v0.7.7 // indirect github.com/mailru/easyjson v0.7.7 // indirect

2
routers/common/middleware.go
View File

@ -165,7 +165,7 @@ func RouteMetrics() func(h http.Handler) http.Handler {
route := chi.RouteContext(req.Context()).RoutePattern() route := chi.RouteContext(req.Context()).RoutePattern()
code := strconv.Itoa(m.WrittenStatus()) code := strconv.Itoa(m.WrittenStatus())
reqDurationHistogram.WithLabelValues(req.Method, code, route).Observe(time.Since(start).Seconds()) reqDurationHistogram.WithLabelValues(req.Method, code, route).Observe(time.Since(start).Seconds())
respSizeHistogram.WithLabelValues(req.Method, code, route).Observe(float64(m.Size())) respSizeHistogram.WithLabelValues(req.Method, code, route).Observe(float64(m.WrittenSize()))
size := req.ContentLength size := req.ContentLength
if size < 0 { if size < 0 {
size = 0 size = 0

22
routers/common/middleware_test.go
View File

@ -1,4 +1,4 @@
package common_test package common
import ( import (
"net/http" "net/http"
@ -6,25 +6,33 @@ import (
"testing" "testing"
"time" "time"
"code.gitea.io/gitea/routers/common"
"github.com/go-chi/chi/v5" "github.com/go-chi/chi/v5"
"github.com/prometheus/client_golang/prometheus/testutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
) )
func TestMetricsMiddlewere(t *testing.T) { func TestMetricsMiddlewere(t *testing.T) {
middleware := RouteMetrics()
middleware := common.RouteMetrics()
r := chi.NewRouter() r := chi.NewRouter()
r.Use(middleware) r.Use(middleware)
r.Get("/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { r.Get("/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("test")) w.Write([]byte("test"))
time.Sleep(5 * time.Millisecond) time.Sleep(5 * time.Millisecond)
})) }))
testServer := httptest.NewServer(r) testServer := httptest.NewServer(r)
// Check all defined metrics
verify := func(i int) {
assert.Equal(t, testutil.CollectAndCount(reqDurationHistogram, "http_server_request_duration"), i)
assert.Equal(t, testutil.CollectAndCount(reqSizeHistogram, "http_server_request_body_size"), i)
assert.Equal(t, testutil.CollectAndCount(respSizeHistogram, "http_server_response_body_size"), i)
assert.Equal(t, testutil.CollectAndCount(reqInflightGauge, "http_server_active_requests"), i)
}
// Check they don't exist before making a request
verify(0)
_, err := http.Get(testServer.URL) _, err := http.Get(testServer.URL)
require.NoError(t, err) require.NoError(t, err)
// Check they do exist after making the request
verify(1)
} }