1
0
mirror of https://gitlab.xiph.org/xiph/ezstream.git synced 2024-11-03 04:17:18 -05:00
Commit Graph

535 Commits

Author SHA1 Message Date
Moritz Grimm
776d57c8dc After hitting the Coverity quota once, switch branches 2017-09-28 12:15:20 +02:00
Moritz Grimm
cb77b073de Explicitly check that m_str is NULL after an error return
Hopefully, this is enough of a hint to Coverity to squelch that
resource leak false positive as well ...
2017-09-25 21:01:55 +02:00
Moritz Grimm
a896f2cc19 Increase test coverage for stream_*() 2017-09-25 20:49:59 +02:00
Moritz Grimm
6466b6ea19 Prefer crashing over no coredump 2017-09-25 19:47:24 +02:00
Moritz Grimm
bcb097a16e Remove more superfluous access() checks
Removes TOCTOU complaints from Coverity
2017-09-25 19:34:37 +02:00
Moritz Grimm
b19b746e5f Revert introduction of !0 pattern for "true" 2017-09-25 18:19:07 +02:00
Moritz Grimm
4551bfdbc0 Remove superfluous access() as unlink() does the same thing 2017-09-25 18:18:07 +02:00
Moritz Grimm
9cb757f17f Add util_* tests 2017-09-25 17:48:39 +02:00
Moritz Grimm
ddc30688e6 Remove unused function 2017-09-25 17:47:12 +02:00
Moritz Grimm
cb997e549c Fix multiple issues in util_shellquote 2017-09-25 17:09:38 +02:00
Moritz Grimm
1d0b9d4801 Simplify util_strrcmp to return a strictly boolean value 2017-09-25 17:07:40 +02:00
Moritz Grimm
f5f130e036 Do not block when trying to lock a PID file; fail immediately 2017-09-25 17:06:38 +02:00
Moritz Grimm
8cc45a3a3d Do not assign save_errno for no reason 2017-09-25 17:05:44 +02:00
Moritz Grimm
448ea0c276 Stop clang CI builds for the time being
This is the easiest way to prevent double-scans with Coverity.
2017-09-20 18:21:52 +02:00
Moritz Grimm
aaa32bf812 Retire rand() in favor of the upcoming getrandom() on Linux
Only the non-getrandom() code paths have been tested at this point.
2017-09-20 18:12:52 +02:00
Moritz Grimm
8499362ce6 Clean up after AM_ICONV no longer allowing multiple invocations 2017-09-20 16:12:07 +02:00
Moritz Grimm
38133919c4 Remove tests for functions that are assumed to be present 2017-09-20 15:52:12 +02:00
Moritz Grimm
2cdda45c16 Unconditionally close allocated stderr FDs 2017-09-20 14:42:19 +02:00
Moritz Grimm
ae85c26cae Fix weird program logic by removing getMetadata() 2017-09-20 13:23:32 +02:00
Moritz Grimm
d40576cd80 Remove superfluous continue; (part 2) 2017-09-20 12:58:09 +02:00
Moritz Grimm
85abb3958c Revert bogus change that introduced a memory leak 2017-09-20 12:55:16 +02:00
Moritz Grimm
454cb5eac3 Mention location of Coverity scan results 2017-09-20 12:42:57 +02:00
Moritz Grimm
6616831590 Switch to a new (unit-tested) metadata handling API 2017-09-20 12:40:33 +02:00
Moritz Grimm
399e66df2b Remove superfluous continue; (CID 171999 et al) 2017-09-20 11:32:34 +02:00
Moritz Grimm
89b4260c83 Ensure that dup() succeeds (CID 172001) 2017-09-20 11:26:35 +02:00
Moritz Grimm
3a471dc164 Assert errstr2 to be not NULL before dereferencing it 2017-09-20 11:20:39 +02:00
Moritz Grimm
1790ca5508 Explicitly exit 0 on success 2017-09-20 00:17:20 +02:00
Moritz Grimm
0fe7a81b8c Reorder defines for consistency 2017-09-19 16:06:09 +02:00
Moritz Grimm
fef9b4625e Fix memory leak (CID 171996) 2017-09-15 20:21:45 +02:00
Moritz Grimm
8ea0197235 Fix memory leak (CID 172413) 2017-09-15 20:13:05 +02:00
Moritz Grimm
f27cdee9d3 Attempt automatic Coverity scans via Travis CI 2017-09-15 19:50:30 +02:00
Moritz Grimm
77f794a41e Rework quoting around metadata
* Do not shell-quote strings in the metadata token expansion function
  * This fixes https://github.com/xiph/ezstream/issues/6
* Expand all tokens at the same time in a way that ensures metadata
  is not additional input to expansion
* Simplify several functions and remove unused functionality
2017-09-15 19:30:52 +02:00
Moritz Grimm
c21d47b8a9 Squelch conversion warnings around tolower() 2017-09-15 19:24:40 +02:00
Moritz Grimm
7729fa9773 Make configuration handling around streaming from stdin more robust 2017-09-15 19:23:16 +02:00
Moritz Grimm
58f615486a Add missing "album" example 2017-09-15 19:17:13 +02:00
Moritz Grimm
f87a5ae9ec Mention "stdin" magic filename 2017-09-15 18:59:59 +02:00
Moritz Grimm
00c18db8c8 Make oggenc example work with decoder examples again 2017-09-15 18:57:40 +02:00
Moritz Grimm
9cb809d5fb Change example to match distributed meta.sh file 2017-09-15 18:52:47 +02:00
Moritz Grimm
59099c6ddf Update util function naming scheme 2017-09-13 23:35:30 +02:00
Moritz Grimm
6d9ab1d581 Reorder code to match header 2017-07-10 11:44:20 +02:00
Moritz Grimm
43e26549f9 Add support for writing PID files 2017-07-10 11:39:00 +02:00
Moritz Grimm
781cfc12c7 Fix an nroff/mandoc error and a warning 2017-07-10 11:24:47 +02:00
Moritz Grimm
88ad0a658c Reference things interesting to developers 2017-07-07 20:38:14 +02:00
Moritz Grimm
e3aefe825e Assume POSIX locale support 2017-07-07 18:50:24 +02:00
Moritz Grimm
75b6962a33 Variable scope reduction 2017-07-07 16:45:10 +02:00
Moritz Grimm
8dc044fee9 Be consistent about using $() instead of `` 2017-07-07 16:44:58 +02:00
Moritz Grimm
f5998edcfd Remove dead ID3Tag structures 2017-07-07 16:44:58 +02:00
Moritz Grimm
cfbbc94751 Assume the availability of POSIX signals 2017-07-07 16:44:58 +02:00
Moritz Grimm
71e5820df1 Make cmdline_parse() restartable 2017-07-07 16:44:58 +02:00
Moritz Grimm
56694daa9d Add CircleCI configuration 2017-07-07 15:33:22 +02:00