1
0
mirror of https://gitlab.xiph.org/xiph/ezstream.git synced 2024-11-03 04:17:18 -05:00

Remove more superfluous access() checks

Removes TOCTOU complaints from Coverity
This commit is contained in:
Moritz Grimm 2017-09-25 19:34:37 +02:00
parent b19b746e5f
commit bcb097a16e

View File

@ -25,9 +25,7 @@ START_TEST(test_util_write_pid_file)
ck_assert_int_eq(fclose(pidfile_2), 0); ck_assert_int_eq(fclose(pidfile_2), 0);
unlink(BUILDDIR "/check_util-write_pid_file.pid"); unlink(BUILDDIR "/check_util-write_pid_file.pid");
ck_assert_int_ne(access(BUILDDIR "/check_util-write_pid_file.pid", F_OK), 0);
ck_assert_int_eq(util_write_pid_file(BUILDDIR "/check_util-write_pid_file.pid"), 0); ck_assert_int_eq(util_write_pid_file(BUILDDIR "/check_util-write_pid_file.pid"), 0);
ck_assert_int_eq(access(BUILDDIR "/check_util-write_pid_file.pid", F_OK), 0);
ck_assert_int_eq(util_write_pid_file(BUILDDIR "/check_util-write_pid_file.pid"), 0); ck_assert_int_eq(util_write_pid_file(BUILDDIR "/check_util-write_pid_file.pid"), 0);
ck_assert_int_eq(unlink(BUILDDIR "/check_util-write_pid_file.pid"), 0); ck_assert_int_eq(unlink(BUILDDIR "/check_util-write_pid_file.pid"), 0);
ck_assert_int_ne(access(BUILDDIR "/check_util-write_pid_file.pid", F_OK), 0); ck_assert_int_ne(access(BUILDDIR "/check_util-write_pid_file.pid", F_OK), 0);