aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2025-02-02 15:07:34 -05:00
Code
amfora/NOTES.md
makeworld 1a2fba92c2 Add subscription manager, fix corrupt read/write & short URI panic 
More info on corrupt reads and writes:
https://github.com/makeworld-the-better-one/amfora/issues/61#issuecomment-735042805

The panic was occuring due to lines like:

    if u[:6] == "about:"

These would cause panics for URIs that were shorter than 6, like "docs/".
strings.HasPrefix was used instead to fix this.
2020-12-05 20:35:15 -05:00

1.2 KiB
Raw Blame History

Notes

Subscriptions (temp)

  • TODO: remove all logger lines

Issues

  • URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL

Upstream Bugs

  • Wrapping messes up on brackets
  • Wrapping panics on strings with brackets and Asian characters
    • Filed cview issue 27
    • The panicking was reported and fixed in Amfora issue 20, but the lines are now just not wrapped
  • Text background not reset on ANSI pages
  • Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
    • Filed issue 26
    • Add some bold back into modal text after this is fixed
  • Bookmark keys aren't deleted, just set to ""
  • Help table cells aren't dynamically wrapped